linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Carlos Bilbao <bilbao@vt.edu>
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] drivers: atm: Follow the indentation coding standard on printks
Date: Thu, 8 Jul 2021 20:15:46 +0200	[thread overview]
Message-ID: <YOdA0vy58Lr6FPeE@lunn.ch> (raw)
In-Reply-To: <108389762.nniJfEyVGO@iron-maiden>

> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index bc8e8d9f176b..8a3ee51e6c9f 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1246,8 +1246,8 @@ static void rx_intr(struct atm_dev *dev)
>                 ((iadev->rx_pkt_cnt - iadev->rx_tmp_cnt) == 0)) {
>          for (i = 1; i <= iadev->num_rx_desc; i++)
>                 free_desc(dev, i);
> -printk("Test logic RUN!!!!\n");
> -        writew( ~(RX_FREEQ_EMPT|RX_EXCP_RCVD),iadev->reass_reg+REASS_MASK_REG);
> +        printk("Test logic RUN!!!!\n");
> + 	writew( ~(RX_FREEQ_EMPT|RX_EXCP_RCVD),iadev->reass_reg+REASS_MASK_REG);
>          iadev->rxing = 1;
>       }

It looks like you turned a set of spaces into a tab for the writew()
line. Please don't make such whitespace changes in the same patch as
other changes.

Yes, lots of things to learn before you get your first patch accepted...

>> +++ b/drivers/atm/zatm.c
> @@ -664,7 +644,7 @@ static int do_tx(struct sk_buff *skb)
>  		EVENT("dsc (0x%lx)\n",(unsigned long) dsc,0);
>  	}
>  	else {
> -printk("NONONONOO!!!!\n");
> +		printk("NONONONOO!!!!\n");
>  		dsc = NULL;

This seems like an error message. So maybe

     pr_err("NONONONOO!!!!\n");

These ATM drivers don't appear to be netdev drivers. There does not
appear to be a struct device available, so you have to fall back to
pr_err(), pr_info() etc.

	  Andrew

  reply	other threads:[~2021-07-08 18:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 13:10 [PATCH] drivers: " Carlos Bilbao
2021-07-08 14:40 ` Greg KH
2021-07-08 15:19   ` [PATCH] drivers: atm: " Carlos Bilbao
2021-07-08 15:48     ` Andrew Lunn
2021-07-08 17:06       ` Carlos Bilbao
2021-07-08 17:23         ` [PATCH net-next v2] " Carlos Bilbao
2021-07-08 17:27       ` Carlos Bilbao
2021-07-08 18:15         ` Andrew Lunn [this message]
2021-07-08 14:53 ` [PATCH] drivers: " Andrew Lunn
2021-07-08 15:08   ` Carlos Bilbao
2021-07-08 21:25 ` Rolf Eike Beer
2021-07-09  0:27   ` Stephen Hemminger
2021-07-09  6:43   ` Helge Deller
2021-07-09 10:30     ` bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOdA0vy58Lr6FPeE@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=3chas3@gmail.com \
    --cc=bilbao@vt.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH net-next v2] drivers: atm: Follow the indentation coding standard on printks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).