From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: phy: reconfigure PHY WOL in resume if WOL option still enabled
Date: Fri, 9 Jul 2021 03:30:22 +0200 [thread overview]
Message-ID: <YOemro4DJEBl+h6N@lunn.ch> (raw)
In-Reply-To: <f167de1d-94cc-7465-2e6f-e1e71b66b009@gmail.com>
> Ah yes you are right, we just skip resume in that case. OK let me think
> about it some more.
The point here is, it is an interrupt, from the perspective of the PHY
hardware and its driver. But the interrupt handler is never being
called because the interrupt output from the chip is not causing an
actual interrupt. Fix that, and your problem goes away. Or you need to
add a whole new mechanism that you are using the interrupt hardware in
the PHY some something else than an actual interrupt.
Andrew
next prev parent reply other threads:[~2021-07-09 1:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 0:42 [PATCH net] net: phy: reconfigure PHY WOL in resume if WOL option still enabled mohammad.athari.ismail
2021-07-08 1:23 ` Andrew Lunn
2021-07-08 2:48 ` Florian Fainelli
2021-07-08 10:10 ` Ismail, Mohammad Athari
2021-07-08 16:41 ` Florian Fainelli
2021-07-08 23:20 ` Ismail, Mohammad Athari
2021-07-08 23:22 ` Florian Fainelli
2021-07-09 1:30 ` Andrew Lunn [this message]
2021-07-09 9:57 ` Russell King (Oracle)
2021-07-08 10:02 ` Ismail, Mohammad Athari
2021-07-08 13:11 ` Andrew Lunn
2021-07-08 23:11 ` Ismail, Mohammad Athari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOemro4DJEBl+h6N@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).