From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0941C4338F for ; Tue, 27 Jul 2021 12:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B71B961A3F for ; Tue, 27 Jul 2021 12:42:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232127AbhG0Mmb (ORCPT ); Tue, 27 Jul 2021 08:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231975AbhG0Mma (ORCPT ); Tue, 27 Jul 2021 08:42:30 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9A81C061757; Tue, 27 Jul 2021 05:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1xxPIZzwnUCYdIgCzjeIvifN5KI2/48eyHiiOas8Njw=; b=pAC+vmFgqg6OQ4sHwUtWijpcB/ u2WL9Et9YUG8LVvi/trCTP2DXHK+8hqfID8wzV5jCJ26NqRRK0cIUKilASn7/jExlSQUmwJFczPfs IO/ElggiatF1tbMR43XmZ0fzLp9RGf4MbsrtPnoHcsgmiRMZvjuYynYOdIGrvYXjl9+5ajS++qPtg OICyVwKxpfEIo2qtLW2dJfk3Rdxq+z//y1oazsj6StrygQeppuaTWaxtD2AgjlmpmoyqMGj5ODZEg pJudGcLCyCQJGRoPC1h0nkZyP0jxsgYGIrSU3PXhw4WVa7O8t4QZNNBQ6ffenp4p/+QhADyVuPrdR hdnBVPyw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8MPk-00Ekef-Qj; Tue, 27 Jul 2021 12:42:28 +0000 Date: Tue, 27 Jul 2021 05:42:28 -0700 From: Luis Chamberlain To: Kalle Valo Cc: Christian Lamparter , Lukas Bulwahn , linux-wireless@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Dwaipayan Ray , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] intersil: remove obsolete prism54 wireless driver Message-ID: References: <20210713054025.32006-1-lukas.bulwahn@gmail.com> <20210715220644.2d2xfututdoimszm@garbanzo> <6f490ee6-4879-cac5-d351-112f21c6b23f@gmail.com> <87mtq8guh7.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mtq8guh7.fsf@codeaurora.org> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 27, 2021 at 09:07:48AM +0300, Kalle Valo wrote: > Christian Lamparter writes: > > > On 16/07/2021 00:06, Luis Chamberlain wrote: > >> On Tue, Jul 13, 2021 at 07:40:25AM +0200, Lukas Bulwahn wrote: > >>> Commit 1d89cae1b47d ("MAINTAINERS: mark prism54 obsolete") indicated the > >>> prism54 driver as obsolete in July 2010. > >>> > >>> Now, after being exposed for ten years to refactoring, general tree-wide > >>> changes and various janitor clean-up, it is really time to delete the > >>> driver for good. > >>> > >>> This was discovered as part of a checkpatch evaluation, investigating all > >>> reports of checkpatch's WARNING:OBSOLETE check. > >>> > >>> Signed-off-by: Lukas Bulwahn > >>> --- > > > > noted. Farewell. > > How do we know that there are no users left? It's surprising how ancient > hardware some people use. Is the driver broken or what? > > (Reads commit 1d89cae1b47d) > > Ah, p54 is supposed to replace prism54. Does that include all the > hardware supported by prism54? There was a one off chipset someone told me about long ago that p54 didn't work for. But that persond disappeared from the face of the earth. Additionally, distributions have been blacklisting prism54 for years now. > If yes, that should be clearly documented > in the commit log and I can add that. Agreed. Feel free to quote the above. Luis