From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH TTY] memcg: drop GFP_KERNEL_ACCOUNT use in tty_save_termios()
Date: Tue, 27 Jul 2021 11:32:07 +0200 [thread overview]
Message-ID: <YP/Sl8a5PqUFZAi5@kroah.com> (raw)
In-Reply-To: <afbaec7c-1872-d43a-1240-e077adc0d6d9@virtuozzo.com>
On Tue, Jul 27, 2021 at 12:26:12PM +0300, Vasily Averin wrote:
> Jiri Slaby pointed that termios are not saved for PTYs and for other
> terminals used inside containers. Therefore accounting for saved
> termios have near to zero impact in real life scenarios.
>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Fixes: 854dd8a572a0 ("memcg: enable accounting for tty-related objects")
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
> drivers/tty/tty_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index e787f6f..a6230b2 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -1493,7 +1493,7 @@ void tty_save_termios(struct tty_struct *tty)
> /* Stash the termios data */
> tp = tty->driver->termios[idx];
> if (tp == NULL) {
> - tp = kmalloc(sizeof(*tp), GFP_KERNEL_ACCOUNT);
> + tp = kmalloc(sizeof(*tp), GFP_KERNEL);
> if (tp == NULL)
> return;
> tty->driver->termios[idx] = tp;
> --
> 1.8.3.1
>
I can just drop the original patch from my tree, it has not gone into my
unmutable branch yet.
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-27 9:32 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8664122a-99d3-7199-869a-781b21b7e712@virtuozzo.com>
2021-04-28 6:51 ` [PATCH v4 00/16] memcg accounting from OpenVZ Vasily Averin
2021-07-15 17:11 ` Shakeel Butt
2021-07-16 4:11 ` Vasily Averin
2021-07-16 12:55 ` Shakeel Butt
2021-07-19 10:44 ` [PATCH v5 " Vasily Averin
2021-07-26 18:59 ` [PATCH v6 00/16] memcg accounting from Vasily Averin
2021-07-26 21:59 ` David Miller
2021-07-27 4:44 ` [PATCH v6 00/16] memcg accounting from OpenVZ Vasily Averin
2021-07-27 5:33 ` [PATCH v7 00/10] " Vasily Averin
[not found] ` <cover.1627362057.git.vvs@virtuozzo.com>
2021-07-27 5:33 ` [PATCH v7 01/10] memcg: enable accounting for mnt_cache entries Vasily Averin
2021-07-27 6:44 ` Shakeel Butt
2021-07-27 7:21 ` Christian Brauner
2021-07-27 5:33 ` [PATCH v7 02/10] memcg: enable accounting for pollfd and select bits arrays Vasily Averin
2021-07-27 21:39 ` Shakeel Butt
2021-07-27 5:33 ` [PATCH v7 03/10] memcg: enable accounting for file lock caches Vasily Averin
2021-07-27 21:41 ` Shakeel Butt
2021-07-27 5:33 ` [PATCH v7 04/10] memcg: enable accounting for fasync_cache Vasily Averin
2021-07-27 21:50 ` Shakeel Butt
2021-07-27 5:33 ` [PATCH v7 05/10] memcg: enable accounting for new namesapces and struct nsproxy Vasily Averin
2021-07-27 21:51 ` Shakeel Butt
2021-07-27 5:33 ` [PATCH v7 06/10] memcg: enable accounting of ipc resources Vasily Averin
2021-07-27 22:33 ` Shakeel Butt
2021-07-27 5:34 ` [PATCH v7 07/10] memcg: enable accounting for signals Vasily Averin
2021-07-27 5:34 ` [PATCH v7 08/10] memcg: enable accounting for posix_timers_cache slab Vasily Averin
2021-07-27 22:33 ` Shakeel Butt
2021-07-27 5:34 ` [PATCH v7 09/10] memcg: enable accounting for tty-related objects Vasily Averin
2021-07-27 6:09 ` Greg Kroah-Hartman
2021-07-27 6:54 ` Jiri Slaby
2021-07-27 8:02 ` Vasily Averin
2021-07-27 9:26 ` [PATCH TTY] memcg: drop GFP_KERNEL_ACCOUNT use in tty_save_termios() Vasily Averin
2021-07-27 9:32 ` Greg Kroah-Hartman [this message]
2022-02-28 9:13 ` [PATCH v2] memcg: enable accounting for tty-related objects Vasily Averin
2021-07-27 9:30 ` [PATCH v7 09/10] " Greg Kroah-Hartman
2021-07-27 5:34 ` [PATCH v7 10/10] memcg: enable accounting for ldt_struct objects Vasily Averin
2021-07-27 22:36 ` Shakeel Butt
[not found] ` <cover.1627321321.git.vvs@virtuozzo.com>
2021-07-26 18:59 ` [PATCH v6 01/16] memcg: enable accounting for net_device and Tx/Rx queues Vasily Averin
2021-07-26 19:00 ` [PATCH v6 02/16] memcg: enable accounting for IP address and routing-related objects Vasily Averin
2021-07-26 19:00 ` [PATCH v6 03/16] memcg: enable accounting for inet_bin_bucket cache Vasily Averin
2021-07-26 19:00 ` [PATCH v6 04/16] memcg: enable accounting for VLAN group array Vasily Averin
2021-07-26 19:00 ` [PATCH v6 05/16] memcg: ipv6/sit: account and don't WARN on ip_tunnel_prl structs allocation Vasily Averin
2021-07-26 19:00 ` [PATCH v6 06/16] memcg: enable accounting for scm_fp_list objects Vasily Averin
2021-07-26 19:00 ` [PATCH v6 07/16] memcg: enable accounting for mnt_cache entries Vasily Averin
2021-07-26 19:00 ` [PATCH v6 08/16] memcg: enable accounting for pollfd and select bits arrays Vasily Averin
2021-07-26 19:01 ` [PATCH v6 09/16] memcg: enable accounting for file lock caches Vasily Averin
2021-07-26 19:01 ` [PATCH v6 10/16] memcg: enable accounting for fasync_cache Vasily Averin
2021-07-26 19:01 ` [PATCH v6 11/16] memcg: enable accounting for new namesapces and struct nsproxy Vasily Averin
2021-07-26 19:58 ` Kirill Tkhai
2021-07-26 19:01 ` [PATCH v6 12/16] memcg: enable accounting of ipc resources Vasily Averin
2021-07-26 19:01 ` [PATCH v6 13/16] memcg: enable accounting for signals Vasily Averin
2021-07-26 19:01 ` [PATCH v6 14/16] memcg: enable accounting for posix_timers_cache slab Vasily Averin
2021-07-26 19:01 ` [PATCH v6 15/16] memcg: enable accounting for tty-related objects Vasily Averin
2021-07-26 19:01 ` [PATCH v6 16/16] memcg: enable accounting for ldt_struct objects Vasily Averin
[not found] ` <cover.1626688654.git.vvs@virtuozzo.com>
2021-07-19 10:44 ` [PATCH v5 01/16] memcg: enable accounting for net_device and Tx/Rx queues Vasily Averin
2021-07-19 10:44 ` [PATCH v5 02/16] memcg: enable accounting for IP address and routing-related objects Vasily Averin
2021-07-19 14:00 ` Dmitry Safonov
2021-07-19 14:22 ` Shakeel Butt
2021-07-19 14:24 ` Dmitry Safonov
2021-07-20 19:26 ` Shakeel Butt
2021-07-26 10:23 ` Vasily Averin
2021-07-26 13:48 ` Shakeel Butt
2021-07-26 16:53 ` [PATCH] memcg: replace in_interrupt() by !in_task() in active_memcg() Vasily Averin
2021-07-26 16:57 ` Shakeel Butt
2021-07-19 10:44 ` [PATCH v5 03/16] memcg: enable accounting for inet_bin_bucket cache Vasily Averin
2021-07-19 10:44 ` [PATCH v5 04/16] memcg: enable accounting for VLAN group array Vasily Averin
2021-07-19 10:44 ` [PATCH v5 05/16] memcg: ipv6/sit: account and don't WARN on ip_tunnel_prl structs allocation Vasily Averin
2021-07-19 10:44 ` [PATCH v5 06/16] memcg: enable accounting for scm_fp_list objects Vasily Averin
2021-07-19 10:45 ` [PATCH v5 07/16] memcg: enable accounting for mnt_cache entries Vasily Averin
2021-07-19 10:45 ` [PATCH v5 08/16] memcg: enable accounting for pollfd and select bits arrays Vasily Averin
2021-07-19 10:45 ` [PATCH v5 09/16] memcg: enable accounting for file lock caches Vasily Averin
2021-07-19 10:45 ` [PATCH v5 10/16] memcg: enable accounting for fasync_cache Vasily Averin
2021-07-19 10:45 ` [PATCH v5 11/16] memcg: enable accounting for new namesapces and struct nsproxy Vasily Averin
2021-07-19 10:45 ` [PATCH v5 12/16] memcg: enable accounting of ipc resources Vasily Averin
2021-07-19 10:45 ` [PATCH v5 13/16] memcg: enable accounting for signals Vasily Averin
2021-07-19 17:32 ` Eric W. Biederman
2021-07-20 8:35 ` Vasily Averin
2021-07-20 14:37 ` Shakeel Butt
2021-07-20 16:42 ` Eric W. Biederman
2021-07-20 19:15 ` Shakeel Butt
2021-07-19 10:45 ` [PATCH v5 14/16] memcg: enable accounting for posix_timers_cache slab Vasily Averin
2021-07-19 10:45 ` [PATCH v5 15/16] memcg: enable accounting for tty-related objects Vasily Averin
2021-07-19 10:46 ` [PATCH v5 16/16] memcg: enable accounting for ldt_struct objects Vasily Averin
2021-04-28 6:51 ` [PATCH v4 01/16] memcg: enable accounting for net_device and Tx/Rx queues Vasily Averin
2021-04-28 6:51 ` [PATCH v4 02/16] memcg: enable accounting for IP address and routing-related objects Vasily Averin
2021-04-28 6:51 ` [PATCH v4 03/16] memcg: enable accounting for inet_bin_bucket cache Vasily Averin
2021-04-28 6:52 ` [PATCH v4 04/16] memcg: enable accounting for VLAN group array Vasily Averin
2021-04-28 6:52 ` [PATCH v4 05/16] memcg: ipv6/sit: account and don't WARN on ip_tunnel_prl structs allocation Vasily Averin
2021-04-28 6:52 ` [PATCH v4 06/16] memcg: enable accounting for scm_fp_list objects Vasily Averin
2021-04-28 6:52 ` [PATCH v4 07/16] memcg: enable accounting for new namesapces and struct nsproxy Vasily Averin
2021-05-07 13:45 ` Serge E. Hallyn
2021-05-07 15:03 ` Christian Brauner
2021-04-28 6:52 ` [PATCH v4 08/16] memcg: enable accounting of ipc resources Vasily Averin
2021-04-28 6:53 ` [PATCH v4 09/16] memcg: enable accounting for mnt_cache entries Vasily Averin
2021-04-28 6:53 ` [PATCH v4 10/16] memcg: enable accounting for pollfd and select bits arrays Vasily Averin
2021-04-28 6:53 ` [PATCH v4 11/16] memcg: enable accounting for signals Vasily Averin
2021-04-28 6:53 ` [PATCH v4 12/16] memcg: enable accounting for posix_timers_cache slab Vasily Averin
2021-05-07 15:48 ` Thomas Gleixner
2021-04-28 6:53 ` [PATCH v4 13/16] memcg: enable accounting for file lock caches Vasily Averin
2021-04-28 6:54 ` [PATCH v4 14/16] memcg: enable accounting for fasync_cache Vasily Averin
2021-04-28 6:54 ` [PATCH v4 15/16] memcg: enable accounting for tty-related objects Vasily Averin
2021-04-28 7:38 ` Greg Kroah-Hartman
2021-04-28 6:54 ` [PATCH v4 16/16] memcg: enable accounting for ldt_struct objects Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP/Sl8a5PqUFZAi5@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cgroups@vger.kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).