From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28AEC4338F for ; Sun, 25 Jul 2021 10:22:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5E8B606A5 for ; Sun, 25 Jul 2021 10:22:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229989AbhGYJmI (ORCPT ); Sun, 25 Jul 2021 05:42:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:37888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbhGYJmH (ORCPT ); Sun, 25 Jul 2021 05:42:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8A470606A5; Sun, 25 Jul 2021 10:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627208558; bh=b9Q32uaI92A0JWOV2A5Hxm/bAl66EgVzXiqYx1br78g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pJnXAZhVKz4ukcc6om8a5MbzQAM5AkLIxmBYFmwz+7ZKOKh8g6+s3Dp9un4FvmaDX 7R45pQ2qstMTIJZKTLJNl+JugEOCYKuZGB81BXlLNUwgDnEX1jVDLLPB7qVqQSeozu 8U1mjwkYTA8zn5Lhc7VKtc4GMkFA3IfiX7xyzTfqUYUGtiH9uJci8NiEKOjL/dIElI HafcMj5WJY+kYZeY13GrmRerbzWEks7OjrZTBIfyXxoNLN4N88VWpranYTfl+kEGiT GwNyKQY7Wbti472hYBiLRFMDl9v5xGC1UZ26YVS64QAXEMsthZHbgOkJ9rj5j/JBOk +Oxqg/SP8nIyw== Date: Sun, 25 Jul 2021 13:22:34 +0300 From: Leon Romanovsky To: Jiapeng Chong Cc: mustafa.ismail@intel.com, shiraz.saleem@intel.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RDMA/irdma: Fix missing error code in irdma_modify_qp_roce() Message-ID: References: <1627036373-69929-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1627036373-69929-1-git-send-email-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2021 at 06:32:53PM +0800, Jiapeng Chong wrote: > From: chongjiapeng > > The error code is missing in this code scenario, add the error code > '-EINVAL' to the return value 'ret'. > > Eliminate the follow smatch warning: > > drivers/infiniband/hw/irdma/verbs.c:1344 irdma_modify_qp_roce() warn: > missing error code 'ret'. > > Reported-by: Abaci Robot > Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs") > Signed-off-by: chongjiapeng > --- > drivers/infiniband/hw/irdma/verbs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c > index 717147e..406c8b05 100644 > --- a/drivers/infiniband/hw/irdma/verbs.c > +++ b/drivers/infiniband/hw/irdma/verbs.c > @@ -1341,6 +1341,7 @@ int irdma_modify_qp_roce(struct ib_qp *ibqp, struct ib_qp_attr *attr, > break; > case IB_QPS_SQD: > if (iwqp->iwarp_state == IRDMA_QP_STATE_SQD) > + ret = -EINVAL; > goto exit; You are missing brackets, it can't compile. > > if (iwqp->iwarp_state != IRDMA_QP_STATE_RTS) { > -- > 1.8.3.1 >