From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD79FC432BE for ; Mon, 26 Jul 2021 01:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEB2760551 for ; Mon, 26 Jul 2021 01:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231404AbhGZA7w (ORCPT ); Sun, 25 Jul 2021 20:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231205AbhGZA7u (ORCPT ); Sun, 25 Jul 2021 20:59:50 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DDEDC061760 for ; Sun, 25 Jul 2021 18:40:20 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id i10so6647456pla.3 for ; Sun, 25 Jul 2021 18:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RKIKuAaTQlG88etJbUulWv2ZbXxRWG1nGC16MCIPM3w=; b=ms8/Jx8P90hOP/FP0L/OO2bILCSysQRSgk6BGqpUNEiyo29FUL08Zmxb3aiqDWglEL hKTWizKDgEI1HdGyb08vp4/EARp+ppjmp8AZro4tp1sv8U2ztEgFcNL0pbp8bO9KbwHt oX4XW2q4v89JVM+RtkxmP8nmccjwirG2A0nG8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RKIKuAaTQlG88etJbUulWv2ZbXxRWG1nGC16MCIPM3w=; b=jABziQK8ANixRbcIXoUcC+czfPHPAZeZ/htjy86EBxtKd/mTiVNGK3/ld+qwbmpYtZ 8Uhq8sRgGjLyxsqE7mQy0uyQWcet4Fj5kjDzEX4aAmhLe5TDiLeOn+uJmVOVNtPAPE1U V2gaT7HfLwH33l17+BG0OFE6VWcoC/421PFbiXhw0VInVPLl4dG+CZzGv0e5JhOCeoOy Bheh2k6Lke1V2otZsYAX7aylqjSZc1utTg/yKgA7VcpE7KcymI1RmWAJSOf+frue1a4y SSDxc3lrl95iup9AKe1UuAXZSqrzNtbgONJ1K4UyGqh9jnx33r+cDcdV2L+RQ5cpvg/k lf7w== X-Gm-Message-State: AOAM5300/DnJoJ6XTzWTeIl1Y/ZH7gXUUMEtVP+OdvOvTWBU2itroIRN agGr0QNS5REta7jlpr05QRzFTA== X-Google-Smtp-Source: ABdhPJyVZ7XxDxNbUh3apH7bz124wc1cFBxqH5WbFeR33S8SV+IY9fRu6qvDNB1w6A+5XSDWqVOpdA== X-Received: by 2002:a05:6a00:9a3:b029:355:d45b:ad9a with SMTP id u35-20020a056a0009a3b0290355d45bad9amr15829812pfg.73.1627263619760; Sun, 25 Jul 2021 18:40:19 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:967a:60e8:38b7:1227]) by smtp.gmail.com with ESMTPSA id v15sm25235523pff.105.2021.07.25.18.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jul 2021 18:40:19 -0700 (PDT) Date: Mon, 26 Jul 2021 10:40:14 +0900 From: Sergey Senozhatsky To: Dafna Hirschfeld Cc: Sergey Senozhatsky , Tomasz Figa , Hans Verkuil , Ricardo Ribalda , Christoph Hellwig , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Collabora Kernel ML Subject: Re: [PATCHv3 7/8] videobuf2: handle V4L2_MEMORY_FLAG_NON_COHERENT flag Message-ID: References: <20210709092027.1050834-1-senozhatsky@chromium.org> <20210709092027.1050834-8-senozhatsky@chromium.org> <0c89ef1e-8abb-8749-bbce-c7e5a2e2f304@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c89ef1e-8abb-8749-bbce-c7e5a2e2f304@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/07/22 19:33), Dafna Hirschfeld wrote: [..] > > int vb2_reqbufs(struct vb2_queue *q, struct v4l2_requestbuffers *req) > > { > > int ret = vb2_verify_memory_type(q, req->memory, req->type); > > + u32 flags = req->flags; > > fill_buf_caps(q, &req->capabilities); > > - return ret ? ret : vb2_core_reqbufs(q, req->memory, 0, &req->count); > > + validate_memory_flags(q, req->memory, &flags); > > + req->flags = flags; > > you can do instead > > validate_memory_flags(q, req->memory, &req->flags); ->flags are u32 for create-bufs and u8 for reqi-bufs. So `*flags = ` can write to ->reserved[] for req-bufs (if the value is huge enough).