From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E2DC4338F for ; Mon, 26 Jul 2021 18:44:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15C0C60F59 for ; Mon, 26 Jul 2021 18:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231791AbhGZSDa (ORCPT ); Mon, 26 Jul 2021 14:03:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbhGZSD3 (ORCPT ); Mon, 26 Jul 2021 14:03:29 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ECBEC061757 for ; Mon, 26 Jul 2021 11:43:57 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id E049E59F; Mon, 26 Jul 2021 20:43:52 +0200 (CEST) Date: Mon, 26 Jul 2021 20:43:28 +0200 From: Joerg Roedel To: Robin Murphy Cc: will@kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, john.garry@huawei.com, dianders@chromium.org Subject: Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types Message-ID: References: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021 at 02:09:00PM +0100, Robin Murphy wrote: > Ha, I had exactly that at one point, except I think in the order of > iommu_is_dma_domain() :) That name is fine too :) > The end result didn't seem to give enough extra clarity to justify the > header churn for me, but I'm happy to be wrong about that if you prefer. Developers look more into the code than into headers, so I think the header churn is worth it to improve code readability. But we can do that on-top of these changes in an extra patch-set which also introduces helpers for other domain types (if it is worth it). Regards, Jörg