From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 466B0C432BE for ; Mon, 26 Jul 2021 23:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 336F260F23 for ; Mon, 26 Jul 2021 23:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233968AbhGZW3w (ORCPT ); Mon, 26 Jul 2021 18:29:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233491AbhGZW3u (ORCPT ); Mon, 26 Jul 2021 18:29:50 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B35B5C061757; Mon, 26 Jul 2021 16:10:18 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id f13so3055412plj.2; Mon, 26 Jul 2021 16:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lGwxyaND0AFp6xjSOU+CS8ALMUm6RpLJV/rJQAwgaMY=; b=FI4linOnbFeTgynUKUdl3/vUVKX3cRbtNpKAnixhYKJ47quOI03wHetguN2dJW9MN9 2RNaBEc+FSEEv7qPVV3tL+r9OpkNZydEbR3oxv/QFVRDpbvAbZQPnIo5fKdZXbgpAdUJ jCsYwZKodRp6pEDf74/79+8VeQsw/Wguz1O0u/oIVopDTLYKhhBZkS8bR4BKklZ/lfkN 2xz3FyahK53ItsEWRnDlEiasq96F4I2mdQE0JPDW3BDoW6+CnxDuj3qOyZ63prmF7pPG 1peP2KLMKD6Zk1GhKeKwe5eOg+WmVBSNuUZqfLL0sQ11OX33McU/Tajd8kut5ZQqId/o 2qlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=lGwxyaND0AFp6xjSOU+CS8ALMUm6RpLJV/rJQAwgaMY=; b=lPC9uM3i8/UoAPrdim01xp1Uisq/BQ5YwjHBUTpCKKTxigzIYSGsjzBdEAoGx0ayS1 GSeOYI0TG4XorF+qo8uyeFGJhUzqukmuMDu5wr8NoUBA9NQIAyL3mAE97bsiIBAAyuIX g6JLO/BKtxAZeT/pVL9aEtoI8dEAj9o62HiVZiC7cMsdOSYZbYSp/YYD4RvDnc3ybLCo 3mRrm1324d/Z9u8SZX+CeSLziprZ9fBPpJ83KWvqXbaoya2cN+PSY9/69tC1Oo8MS/t/ 6LIUioqhkjOz9fsB167EA43b3Yv4FRtZqMbl3Q1SW+hmIYmfjoX7T2boNpWFKNQnx7se xm0g== X-Gm-Message-State: AOAM533PiT69jjLfSVbLszvy8/mUzP4oXGDxG9peUrZShVP9LxhmzMzF RyZjK72vU2lSSCv39KHPwnQ= X-Google-Smtp-Source: ABdhPJwbc7zcK+b/oi8A8VWQpBSU8Iwv1rvIPdhCEViCl4PjtVnB8x0zjkbguUnDtaY8v2VxM++r4g== X-Received: by 2002:a17:902:c946:b029:12c:3cf9:36c4 with SMTP id i6-20020a170902c946b029012c3cf936c4mr2473932pla.84.1627341018139; Mon, 26 Jul 2021 16:10:18 -0700 (PDT) Received: from localhost (udp264798uds.hawaiiantel.net. [72.253.242.87]) by smtp.gmail.com with ESMTPSA id b3sm1149623pfi.179.2021.07.26.16.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 16:10:17 -0700 (PDT) Sender: Tejun Heo Date: Mon, 26 Jul 2021 13:10:16 -1000 From: Tejun Heo To: Waiman Long Cc: Zefan Li , Johannes Weiner , Jonathan Corbet , Shuah Khan , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Roman Gushchin , Phil Auld , Peter Zijlstra , Juri Lelli , Frederic Weisbecker , Marcelo Tosatti , Michal =?iso-8859-1?Q?Koutn=FD?= Subject: Re: [PATCH v3 3/9] cgroup/cpuset: Fix violation of cpuset locking rule Message-ID: References: <20210720141834.10624-1-longman@redhat.com> <20210720141834.10624-4-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720141834.10624-4-longman@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2021 at 10:18:28AM -0400, Waiman Long wrote: > The cpuset fields that manage partition root state do not strictly > follow the cpuset locking rule that update to cpuset has to be done > with both the callback_lock and cpuset_mutex held. This is now fixed > by making sure that the locking rule is upheld. > > Fixes: 3881b86128d0 ("cpuset: Add an error state to cpuset.sched.partition") > Fixes: 4b842da276a8 ("cpuset: Make CPU hotplug work with partition) > Signed-off-by: Waiman Long Applied to cgroup/for-5.15. Thanks. -- tejun