From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47644C47E48 for ; Thu, 15 Jul 2021 13:07:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 318EC613C1 for ; Thu, 15 Jul 2021 13:07:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236359AbhGONJy (ORCPT ); Thu, 15 Jul 2021 09:09:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:47718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbhGONJw (ORCPT ); Thu, 15 Jul 2021 09:09:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 352EB613C4; Thu, 15 Jul 2021 13:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626354419; bh=6f93Qyz7TatzFLNNdICtO24cj/QiivXwnorMniZD5aY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C3womNCwGX7T38B94tLBNHsU1T59lcB4G6b7HKOzl/Ez1LnN3wALJxcA170pkA9cL 5su5kqtDMRdbQ6SuPxUAiX+ATshJK43FywTfruioFYUAI+6ewiKWrKS0/A6xV4bMl6 nN3L7EMJVYUhNu4rVVjkuDfRlOLYGnxtZf3xC0W4= Date: Thu, 15 Jul 2021 15:06:57 +0200 From: Greg Kroah-Hartman To: Jan Kara Cc: Naresh Kamboju , Holger Kiehl , linux-kernel , Linus Torvalds , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, lkft-triage@lists.linaro.org, Pavel Machek , Jon Hunter , Florian Fainelli , linux-stable , Paolo Valente , Jens Axboe Subject: Re: [PATCH 5.13 000/800] 5.13.2-rc1 review Message-ID: References: <20210712060912.995381202@linuxfoundation.org> <68b6051-09c-9dc8-4b52-c4e766fee5@praktifix.dwd.de> <50fb4713-6b5d-b5e0-786a-6ece57896d2f@praktifix.dwd.de> <20210715122758.GB31920@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715122758.GB31920@quack2.suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 02:27:58PM +0200, Jan Kara wrote: > On Wed 14-07-21 16:26:52, Greg Kroah-Hartman wrote: > > On Wed, Jul 14, 2021 at 07:29:26PM +0530, Naresh Kamboju wrote: > > > On Wed, 14 Jul 2021 at 19:22, Naresh Kamboju wrote: > > > > > > > > On Wed, 14 Jul 2021 at 19:01, Greg Kroah-Hartman > > > > wrote: > > > > > > > > > > > > > > > > > > My two cents, > > > > While running ssuite long running stress testing we have noticed deadlock. > > > > > > > > > So if you drop that, all works well? I'll go drop that from the queues > > > > > now. > > > > > > > > Let me drop that patch and test it again. > > > > > > > > Crash log, > > > > > > > > [ 1957.278399] ============================================ > > > > [ 1957.283717] WARNING: possible recursive locking detected > > > > [ 1957.289031] 5.13.2-rc1 #1 Not tainted > > > > [ 1957.292703] -------------------------------------------- > > > > [ 1957.298016] kworker/u8:7/236 is trying to acquire lock: > > > > [ 1957.303241] ffff8cc203f92c38 (&bfqd->lock){-.-.}-{2:2}, at: > > > > bfq_finish_requeue_request+0x55/0x500 [bfq] > > > > [ 1957.312643] > > > > [ 1957.312643] but task is already holding lock: > > > > [ 1957.318467] ffff8cc203f92c38 (&bfqd->lock){-.-.}-{2:2}, at: > > > > bfq_insert_requests+0x81/0x1750 [bfq] > > > > [ 1957.327334] > > > > [ 1957.327334] other info that might help us debug this: > > > > [ 1957.333852] Possible unsafe locking scenario: > > > > [ 1957.333852] > > > > [ 1957.339762] CPU0 > > > > [ 1957.342206] ---- > > > > [ 1957.344651] lock(&bfqd->lock); > > > > [ 1957.347873] lock(&bfqd->lock); > > > > [ 1957.351097] > > > > [ 1957.351097] *** DEADLOCK *** > > > > [ 1957.351097] > > > > > > Also noticed on stable-rc 5.12.17-rc1. > > > > I dropped the same patch from there as well already, thanks. > > OK, when you dropped this patch, please also drop upstream commit > fd2ef39cc9a6b ("blk: Fix lock inversion between ioc lock and bfqd lock"). That commit did not end up in the tree either, so all should be good. thanks, greg k-h