From: Matthew Wilcox <willy@infradead.org>
To: Zhansaya Bagdauletkyzy <zhansayabagdaulet@gmail.com>
Cc: akpm@linux-foundation.org, tyhicks@linux.microsoft.com,
pasha.tatashin@soleen.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: KSM: fix ksm_run data type
Date: Thu, 15 Jul 2021 19:17:16 +0100 [thread overview]
Message-ID: <YPB7rBlU1SinK6FR@casper.infradead.org> (raw)
In-Reply-To: <343394260f599d940cacc37f1dcc0309239ae220.1626371112.git.zhansayabagdaulet@gmail.com>
On Fri, Jul 16, 2021 at 12:01:01AM +0600, Zhansaya Bagdauletkyzy wrote:
> +++ b/mm/ksm.c
> @@ -289,7 +289,7 @@ static int ksm_nr_node_ids = 1;
> #define KSM_RUN_MERGE 1
> #define KSM_RUN_UNMERGE 2
> #define KSM_RUN_OFFLINE 4
> -static unsigned long ksm_run = KSM_RUN_STOP;
> +static unsigned int ksm_run = KSM_RUN_STOP;
Should this be an enum instead?
next prev parent reply other threads:[~2021-07-15 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 18:00 [PATCH 0/2] mm: KSM: fix data types Zhansaya Bagdauletkyzy
2021-07-15 18:01 ` [PATCH 1/2] mm: KSM: fix ksm_run data type Zhansaya Bagdauletkyzy
2021-07-15 18:10 ` Pavel Tatashin
2021-07-15 18:17 ` Matthew Wilcox [this message]
2021-07-15 18:21 ` Pavel Tatashin
2021-07-15 18:30 ` Matthew Wilcox
2021-07-15 18:57 ` Pavel Tatashin
2021-07-15 19:06 ` Pavel Tatashin
2021-07-15 18:01 ` [PATCH 2/2] mm: KSM: fix " Zhansaya Bagdauletkyzy
2021-07-15 18:10 ` Pavel Tatashin
2021-07-16 4:42 ` Zhansaya Bagdauletkyzy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPB7rBlU1SinK6FR@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=tyhicks@linux.microsoft.com \
--cc=zhansayabagdaulet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).