From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AD8C636C9 for ; Thu, 15 Jul 2021 20:21:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1C7C613D3 for ; Thu, 15 Jul 2021 20:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237971AbhGOUYk (ORCPT ); Thu, 15 Jul 2021 16:24:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:56198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235437AbhGOUYg (ORCPT ); Thu, 15 Jul 2021 16:24:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1E67613D3; Thu, 15 Jul 2021 20:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626380503; bh=SYaLs1ohm9nYnP1HBgtNYafbqW6mrbrRwfra8T6TbfI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ibnLHtpbPDis+sYzL9JoCTBT3yU1Rdg7/gNT4rGTDwOW0p3vyxjfRMnXtJ+1xU9qp MIOYtQnNgYc34pAH6C3n96kc3kKfP5ZBWGbP3JVUzZeJ19LKZsovxRtdRTCUYl4oTp 2T12IksbcNQ34MMr5yz8UqUxIOpJCeimh0Lmgx+KVoNuf8ROjhOb6SKTROcX3ykl1/ WwpT0WuIN+iCQ+b71ROfcxiMWklh1HT8Fqq1b/NsEfYSfmLQuyJu6lKibQgnU+UmWL 3p/Mo6pZpjLiWriba2UEnrltPJuhOcKsda7IIgSGnizWEFFGoKQQUwDrRjO7kOyeY3 rfX3xa6+boFMg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 9D3FB403F2; Thu, 15 Jul 2021 17:21:40 -0300 (-03) Date: Thu, 15 Jul 2021 17:21:40 -0300 From: Arnaldo Carvalho de Melo To: Riccardo Mancini Cc: Ian Rogers , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 11/20] perf session: cleanup trace_event Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jul 15, 2021 at 06:07:16PM +0200, Riccardo Mancini escreveu: > ASan reports several memory leaks when running the perf test > "82: Use vfs_getname probe to get syscall args filenames", many of which > are related to session->tevent. > This patch will solve this problem, then next patch will fix the remaining > memory leaks in perf-script. > This bug is due to a missing deallocation of the trace_event data > strutures. > > This patch adds the missing trace_event__cleanup in > perf_session__delete. Thanks, applied. - Arnaldo > Signed-off-by: Riccardo Mancini > --- > tools/perf/util/session.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index e9c929a39973ace9..51f72740291267c5 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -306,6 +306,7 @@ void perf_session__delete(struct perf_session *session) > evlist__delete(session->evlist); > perf_data__close(session->data); > } > + trace_event__cleanup(&session->tevent); > free(session); > } > > -- > 2.31.1 > -- - Arnaldo