linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support
Date: Fri, 16 Jul 2021 10:42:53 +0100	[thread overview]
Message-ID: <YPFUnQaC9gWUY1Z4@google.com> (raw)
In-Reply-To: <b98a99330e250b51d09c904c9e274ae461118238.camel@ew.tq-group.com>

On Fri, 16 Jul 2021, Matthias Schiffer wrote:

> On Fri, 2021-07-16 at 10:20 +0100, Lee Jones wrote:
> > On Fri, 02 Jul 2021, Matthias Schiffer wrote:
> > 
> > > Updated patch series:
> > > 
> > > - A number of new patches (more hardware support and a few fixes)
> > > - Patches 1-3 have gained Fixes tags
> > > - Patch 2 depends on 1, so maybe we can push the GPIO patch through the
> > >   MFD tree to keep them together?
> > > - The change in patch 7 was somewhat controversial. I've added a
> > >   warning, but it is the last patch of the series, so it doesn't affect
> > >   the rest of the series if it is rejected.
> > > 
> > > 
> > > Matthias Schiffer (7):
> > >   gpio: tqmx86: really make IRQ optional
> > >   mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set
> > >   mfd: tqmx86: remove incorrect TQMx90UC board ID
> > >   mfd: tqmx86: fix typo in "platform"
> > >   mfd: tqmx86: add support for TQMx110EB and TQMxE40x
> > >   mfd: tqmx86: add support for TQ-Systems DMI IDs
> > >   mfd: tqmx86: assume 24MHz LPC clock for unknown boards
> > > 
> > >  drivers/gpio/gpio-tqmx86.c |  6 ++---
> > >  drivers/mfd/tqmx86.c       | 48 ++++++++++++++++++++++++++++++--------
> > >  2 files changed, 41 insertions(+), 13 deletions(-)
> > 
> > Patches look good.
> > 
> > Could you please collect up Andrew's acks, remove the suggested Fixes:
> > lines and resubmit please?
> 
> Are you referring to the Fixes: line in "[PATCH v2 3/7] mfd: tqmx86:
> remove incorrect TQMx90UC board ID"?

I'm referring to the lines that Andrew said did not qualify.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

      reply	other threads:[~2021-07-16  9:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 12:23 [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Matthias Schiffer
2021-07-02 12:23 ` [PATCH v2 1/7] gpio: tqmx86: really make IRQ optional Matthias Schiffer
2021-07-02 13:45   ` Andrew Lunn
2021-07-02 14:14     ` Andy Shevchenko
2021-07-02 12:23 ` [PATCH v2 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set Matthias Schiffer
2021-07-02 13:52   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 3/7] mfd: tqmx86: remove incorrect TQMx90UC board ID Matthias Schiffer
2021-07-02 13:56   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 4/7] mfd: tqmx86: fix typo in "platform" Matthias Schiffer
2021-07-02 14:00   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 5/7] mfd: tqmx86: add support for TQMx110EB and TQMxE40x Matthias Schiffer
2021-07-02 14:01   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 6/7] mfd: tqmx86: add support for TQ-Systems DMI IDs Matthias Schiffer
2021-07-02 14:01   ` Andrew Lunn
2021-07-02 12:23 ` [PATCH v2 7/7] mfd: tqmx86: assume 24MHz LPC clock for unknown boards Matthias Schiffer
2021-07-02 14:04   ` Andrew Lunn
2021-07-02 13:41 ` [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Andrew Lunn
2021-07-05  7:13   ` Matthias Schiffer
2021-07-16  9:20 ` Lee Jones
2021-07-16  9:23   ` Matthias Schiffer
2021-07-16  9:42     ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPFUnQaC9gWUY1Z4@google.com \
    --to=lee.jones@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.schiffer@ew.tq-group.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).