From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2030C636CB for ; Sat, 17 Jul 2021 17:35:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 892556101D for ; Sat, 17 Jul 2021 17:35:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233822AbhGQRh6 (ORCPT ); Sat, 17 Jul 2021 13:37:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:34784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233280AbhGQRhz (ORCPT ); Sat, 17 Jul 2021 13:37:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5D75B61151; Sat, 17 Jul 2021 17:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626543297; bh=cNLDAL8cqetw2WohunGLgyT4MIPB2gmlE1nTue+sV7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MgVmORWCi6BHeqxwX4gkgMDUCvIfr3/p+OA9sOzzP2Ghb9YMJIif7XlBEXSQd4qGU /W7JvDXtpajlLTIOT6Ki/jkAxA6rXnJFwNJVmZWyhkkYYtPwp2wLZg95qe1MgEb2gl QZcYPcL6boZjVw+15YB1NCRlnf6YnvIYDq5V0LfU= Date: Sat, 17 Jul 2021 19:34:51 +0200 From: Greg Kroah-Hartman To: Justin Forbes Cc: LKML , Stable , Mathias Nyman , Vinod Koul , Moritz Fischer Subject: Re: [PATCH 5.13 024/800] usb: renesas-xhci: Fix handling of unknown ROM state Message-ID: References: <20210712060912.995381202@linuxfoundation.org> <20210712060916.499546891@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 08:39:19AM -0500, Justin Forbes wrote: > On Mon, Jul 12, 2021 at 2:31 AM Greg Kroah-Hartman > wrote: > > > > From: Moritz Fischer > > > > commit d143825baf15f204dac60acdf95e428182aa3374 upstream. > > > > The ROM load sometimes seems to return an unknown status > > (RENESAS_ROM_STATUS_NO_RESULT) instead of success / fail. > > > > If the ROM load indeed failed this leads to failures when trying to > > communicate with the controller later on. > > > > Attempt to load firmware using RAM load in those cases. > > > > Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201") > > Cc: stable@vger.kernel.org > > Cc: Mathias Nyman > > Cc: Greg Kroah-Hartman > > Cc: Vinod Koul > > Tested-by: Vinod Koul > > Reviewed-by: Vinod Koul > > Signed-off-by: Moritz Fischer > > Link: https://lore.kernel.org/r/20210615153758.253572-1-mdf@kernel.org > > Signed-off-by: Greg Kroah-Hartman > > > > After sending out 5.12.17 for testing, we had a user complain that all > of their USB devices disappeared with the error: > > Jul 15 23:18:53 kernel: xhci_hcd 0000:04:00.0: Direct firmware load > for renesas_usb_fw.mem failed with error -2 > Jul 15 23:18:53 kernel: xhci_hcd 0000:04:00.0: request_firmware failed: -2 > Jul 15 23:18:53 kernel: xhci_hcd: probe of 0000:04:00.0 failed with error -2 > > After first assuming that something was missing in the backport to > 5.12, I had the user try 5.13.2, and then 5.14-rc1. Both of those > failed in the same way, so it is not working in the current Linus tree > either. Reverting this patch fixed the issue. Can you send a revert for this so I can get that into Linus's tree and then all stable releases as well? thanks, greg k-h