From: Matthew Wilcox <willy@infradead.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Boqun Feng <boqun.feng@gmail.com>,
Zhouyi Zhou <zhouzhouyi@gmail.com>,
paulmck@kernel.org,
Oleksandr Natalenko <oleksandr@natalenko.name>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Chris Clayton <chris2553@googlemail.com>,
Chris Rankin <rankincj@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
rcu <rcu@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
"Huang, Ying" <ying.huang@intel.com>,
gregkh@linuxfoundation.org
Subject: Re: linux-5.13.2: warning from kernel/rcu/tree_plugin.h:359
Date: Mon, 19 Jul 2021 12:22:17 +0100 [thread overview]
Message-ID: <YPVgaY6uw59Fqg5x@casper.infradead.org> (raw)
In-Reply-To: <08803f78-3e99-6b3f-e809-5828fe47cf06@huawei.com>
On Mon, Jul 19, 2021 at 07:12:58PM +0800, Miaohe Lin wrote:
> When in the commit 2799e77529c2a, we're using the percpu_ref to serialize against
> concurrent swapoff, i.e. there's percpu_ref inside get_swap_device() instead of
> rcu_read_lock(). Please see commit 63d8620ecf93 ("mm/swapfile: use percpu_ref to
> serialize against concurrent swapoff") for detail.
Oh, so this is a backport problem. 2799e77529c2 was backported without
its prerequisite 63d8620ecf93. Greg, probably best to just drop
2799e77529c2 from all stable trees; the race described is not very
important (swapoff vs reading a page back from that swap device).
next prev parent reply other threads:[~2021-07-19 11:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 20:22 linux-5.13.2: warning from kernel/rcu/tree_plugin.h:359 Chris Clayton
2021-07-18 21:01 ` Oleksandr Natalenko
2021-07-18 21:03 ` Oleksandr Natalenko
2021-07-18 21:22 ` Matthew Wilcox
2021-07-18 21:36 ` Chris Clayton
2021-07-18 21:59 ` Paul E. McKenney
2021-07-18 22:51 ` Matthew Wilcox
2021-07-19 1:53 ` Paul E. McKenney
2021-07-19 2:24 ` Zhouyi Zhou
2021-07-19 2:27 ` Zhouyi Zhou
2021-07-19 2:43 ` Matthew Wilcox
2021-07-19 2:59 ` Zhouyi Zhou
2021-07-19 10:14 ` Boqun Feng
2021-07-19 11:12 ` Miaohe Lin
2021-07-19 11:17 ` Oleksandr Natalenko
2021-07-19 11:22 ` Matthew Wilcox [this message]
2021-07-19 11:50 ` Miaohe Lin
2021-07-19 11:59 ` Oleksandr Natalenko
2021-07-19 12:08 ` Miaohe Lin
2021-07-19 12:12 ` Oleksandr Natalenko
2021-07-19 12:16 ` Matthew Wilcox
2021-07-19 12:23 ` Oleksandr Natalenko
2021-07-19 16:47 ` Zhouyi Zhou
2021-07-19 16:56 ` Zhouyi Zhou
2021-07-22 7:30 ` Chris Clayton
2021-07-22 8:57 ` Zhouyi Zhou
2021-07-22 12:36 ` Matthew Wilcox
2021-07-22 13:26 ` Greg KH
2021-07-22 14:00 ` Greg KH
2021-07-23 1:51 ` Miaohe Lin
2021-07-23 7:02 ` Greg KH
2021-07-23 7:13 ` Miaohe Lin
2021-07-22 17:44 ` Zhouyi Zhou
2021-07-22 14:05 ` Paul E. McKenney
2021-07-19 12:17 ` Miaohe Lin
2021-07-19 7:32 ` Chris Clayton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPVgaY6uw59Fqg5x@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=chris2553@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=oleksandr@natalenko.name \
--cc=paulmck@kernel.org \
--cc=rankincj@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=ying.huang@intel.com \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).