From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9286EC07E9B for ; Tue, 20 Jul 2021 14:15:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72E2361164 for ; Tue, 20 Jul 2021 14:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239155AbhGTNeD (ORCPT ); Tue, 20 Jul 2021 09:34:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239339AbhGTN2A (ORCPT ); Tue, 20 Jul 2021 09:28:00 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA4C1C061762 for ; Tue, 20 Jul 2021 07:08:36 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id o30-20020a05600c511eb029022e0571d1a0so2125255wms.5 for ; Tue, 20 Jul 2021 07:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=vdj/876kbj9otjV0SXLMGMJadLoRz/MWE+rabeKCiRs=; b=ez54kYqit1kD8uQyQxcQe8M9Z5tOkNmZnsUiOZGUePvnwGXLbG946Dkr03BbDFCQpf s8/LFEKMgoxoja8qKu2j/lNl53l/KhEzxNacpIh4zg1yF6wm3BbMo2EjzOu7JKkpGMPn Ye0fDTd99UcNVzQ9C+eWxJhBhNj1sn4lZIbr4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=vdj/876kbj9otjV0SXLMGMJadLoRz/MWE+rabeKCiRs=; b=ZIxi9HVHIEsKgRS+WDUkZ3EiQ5RskdFYlqveMkoRnMJ9wYllDPcC/KeOEduiDwsGpg 1PD+JObg/nEphB7AHNJBziMuUx3SJHqJTR3TUUNjWitZ+oPF7gnyB/jt9njCzQZby8/e p2KqAA239iXVDWYiXl3Ho5kV1jkfqELbLayrR3QjmYVX189g7k1ZNfg2dEN2KVkLtHFq qaLPXicq6xnAQgFRd/JgEu1awuDLiolDImqJU0g1bj2hBbmFjBpdtRruBSHvoQ586Vny Omh897OCBx4KappPitSCZ03YGlT4siKKuj4ToxhNsE+GAaT3L+v5jYX/2EELbmyc2jyZ +iNA== X-Gm-Message-State: AOAM532oO5kQEx/4+SECsGfYyCx59Dzx/8PEhv52mLLg3INgaWmxei82 XKkOT31TXCYUZqtroEYFDGdxTwLWjuucAA== X-Google-Smtp-Source: ABdhPJxMU++IY5nRb5dHWOBB6cPsmCpD91+OygobkfIENh5fKb+3nWKdQaWO6CUlP10eV7boXeOv2Q== X-Received: by 2002:a05:600c:35c1:: with SMTP id r1mr31996863wmq.0.1626790115511; Tue, 20 Jul 2021 07:08:35 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id a207sm3004661wme.27.2021.07.20.07.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 07:08:35 -0700 (PDT) Date: Tue, 20 Jul 2021 16:08:33 +0200 From: Daniel Vetter To: Rob Clark Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Rob Clark , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , open list Subject: Re: [PATCH 04/11] drm: Drop drm_gem_object_put_locked() Message-ID: Mail-Followup-To: Rob Clark , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Rob Clark , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , open list References: <20210717202924.987514-1-robdclark@gmail.com> <20210717202924.987514-5-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210717202924.987514-5-robdclark@gmail.com> X-Operating-System: Linux phenom 5.10.0-7-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 01:29:06PM -0700, Rob Clark wrote: > From: Rob Clark > > Now that no one is using it, remove it. > > Signed-off-by: Rob Clark Yay! Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_gem.c | 22 ---------------------- > include/drm/drm_gem.h | 2 -- > 2 files changed, 24 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > index 9989425e9875..c8866788b761 100644 > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -974,28 +974,6 @@ drm_gem_object_free(struct kref *kref) > } > EXPORT_SYMBOL(drm_gem_object_free); > > -/** > - * drm_gem_object_put_locked - release a GEM buffer object reference > - * @obj: GEM buffer object > - * > - * This releases a reference to @obj. Callers must hold the > - * &drm_device.struct_mutex lock when calling this function, even when the > - * driver doesn't use &drm_device.struct_mutex for anything. > - * > - * For drivers not encumbered with legacy locking use > - * drm_gem_object_put() instead. > - */ > -void > -drm_gem_object_put_locked(struct drm_gem_object *obj) > -{ > - if (obj) { > - WARN_ON(!mutex_is_locked(&obj->dev->struct_mutex)); > - > - kref_put(&obj->refcount, drm_gem_object_free); > - } > -} > -EXPORT_SYMBOL(drm_gem_object_put_locked); > - > /** > * drm_gem_vm_open - vma->ops->open implementation for GEM > * @vma: VM area structure > diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h > index 240049566592..35e7f44c2a75 100644 > --- a/include/drm/drm_gem.h > +++ b/include/drm/drm_gem.h > @@ -384,8 +384,6 @@ drm_gem_object_put(struct drm_gem_object *obj) > __drm_gem_object_put(obj); > } > > -void drm_gem_object_put_locked(struct drm_gem_object *obj); > - > int drm_gem_handle_create(struct drm_file *file_priv, > struct drm_gem_object *obj, > u32 *handlep); > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch