From: Wolfram Sang <wsa@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: mpc: Poll for MCF
Date: Tue, 20 Jul 2021 22:33:30 +0200 [thread overview]
Message-ID: <YPczGp5FcxWjzo60@kunai> (raw)
In-Reply-To: <20210715205832.17879-1-chris.packham@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Fri, Jul 16, 2021 at 08:58:32AM +1200, Chris Packham wrote:
> During some transfers the bus can still be busy when an interrupt is
> received. Commit 763778cd7926 ("i2c: mpc: Restore reread of I2C status
> register") attempted to address this by re-reading MPC_I2C_SR once but
> that just made it less likely to happen without actually preventing it.
> Instead of a single re-read, poll with a timeout so that the bus is given
> enough time to settle but a genuine stuck SCL is still noticed.
>
> Fixes: 1538d82f4647 ("i2c: mpc: Interrupt driven transfer")
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-07-20 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 20:58 [PATCH v2] i2c: mpc: Poll for MCF Chris Packham
2021-07-20 20:33 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPczGp5FcxWjzo60@kunai \
--to=wsa@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).