From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF02C12002
	for <linux-kernel@archiver.kernel.org>; Wed, 21 Jul 2021 06:48:13 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 7278561029
	for <linux-kernel@archiver.kernel.org>; Wed, 21 Jul 2021 06:48:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234708AbhGUGHb (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 21 Jul 2021 02:07:31 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35622 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233349AbhGUGFc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Jul 2021 02:05:32 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D600C061574;
        Tue, 20 Jul 2021 23:46:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=pyHtN+Xci42zugXAkTf9n9TxewDvmHNLWNT2t946HgU=; b=aeVaTNPESISav9LEVCg5sedbVI
        LpG/b5gousUA1XZBMh5DdRuzJJT1GpqhgkcXVAEensgLNXVOATCLgnUvwEGRXfLDDrrt/a/rgNyTu
        Jhp4JCFNZB+Cx0ei2l6dVdakCkximDNOdd7NB8FL3as59wJFngTHVpL8lzErfGKelO41AAZZjYGNN
        uYwWHvaAr1+5jnN6ELJ79TPPxr74ELaB+Jdjrromp48jmWUs1GrdLxsMYWtXkoy+dd2ccxxM9sRN5
        b2CRKxwlpKSajpSNHkEHM+/JMElL3dgoI9vgjdKHQkHXymj3VV8onUBeWZ8LdUjccn08aFam+h2Sw
        XFCWIEFQ==;
Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1m65zI-008tO6-Gx; Wed, 21 Jul 2021 06:45:52 +0000
Date:   Wed, 21 Jul 2021 07:45:48 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        Mark Zhang <markz@mellanox.com>
Subject: Re: [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level
 functions
Message-ID: <YPfCnIfVmolgfMPF@infradead.org>
References: <cover.1626846795.git.leonro@nvidia.com>
 <328963df8e30bfc040c846d2c7626becd341f3ec.1626846795.git.leonro@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <328963df8e30bfc040c846d2c7626becd341f3ec.1626846795.git.leonro@nvidia.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by casper.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +/**
> + * ib_create_qp_kernel - Creates a kernel QP associated with the specified

Any reason this function is renamed?  This seems rather unrelated to
the rest of th patch.

> + *   protection domain.
>   * @pd: The protection domain associated with the QP.
>   * @qp_init_attr: A list of initial attributes required to create the
>   *   QP.  If QP creation succeeds, then the attributes are updated to
>   *   the actual capabilities of the created QP.
>   * @caller: caller's build-time module name
> - *
> - * NOTE: for user qp use ib_create_qp_user with valid udata!
>   */

Also a kerneldoc comment for a function that is an implementation
detail is actively harmful.  Please document ib_create_qp instead.