From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885ADC4338F for ; Thu, 22 Jul 2021 22:17:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E1FD60EB0 for ; Thu, 22 Jul 2021 22:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232303AbhGVVgx (ORCPT ); Thu, 22 Jul 2021 17:36:53 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:39787 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232024AbhGVVgv (ORCPT ); Thu, 22 Jul 2021 17:36:51 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 16MMHGMV021590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jul 2021 18:17:16 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3A54115C37C0; Thu, 22 Jul 2021 18:17:16 -0400 (EDT) Date: Thu, 22 Jul 2021 18:17:16 -0400 From: "Theodore Ts'o" To: Lee Jones Cc: linux-kernel@vger.kernel.org, Andreas Dilger , Remy Card , "David S. Miller" , linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/1] fs: ext4: namei: trivial: Fix a couple of small whitespace issues Message-ID: References: <20210520125558.3476318-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 12:35:43PM +0100, Lee Jones wrote: > On Thu, 20 May 2021, Lee Jones wrote: > > > Cc: "Theodore Ts'o" > > Cc: Andreas Dilger > > Cc: Remy Card > > Cc: "David S. Miller" > > Cc: linux-ext4@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > fs/ext4/namei.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Any news on this please? > > Would you like me to submit a [RESEND]? Please don't send "checkpatch.pl --file" patches for the ext4 file system; if you must, please focus on files in the drivers directory, where they are more welcome. If developers are making changes to a file, fixing some checkpatch.pl whines is fine, but white-sapace only changes just obfuscates "git blame" code archology, and so the costs far outwieghs the costs. "Fix" is also not the right verb to use. For more information please see [1]. [1] https://gist.github.com/17twenty/8154928 If you are looking for subtantive ways of contributing to the ext4 file system, feel free to look at various syzbot warnings[2] and try to figure out what is going on there. [2] https://syzkaller.appspot.com/upstream (In some cases, the syzbot complaint has already been fixed, and it's just a matter of letting syzbot knoww that it has since been fixed by a particular commit. See [3] for more details.) [3] https://github.com/google/syzkaller/blob/master/docs/syzbot.md Cheers, - Ted