From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Dennis Giaya <dgiaya@whoi.edu>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL
Date: Fri, 23 Jul 2021 15:28:40 +0300 [thread overview]
Message-ID: <YPq1+NzJeqLZVctW@smile.fi.intel.com> (raw)
In-Reply-To: <0acef8aa86d69cac0ea1a3dbdafc41625580e0eb.camel@whoi.edu>
On Thu, Jul 22, 2021 at 09:05:13PM +0000, Dennis Giaya wrote:
> Andy,
>
> I've tested this out on my hardware that uses an external oscillator
> 'osc' (as opposed to external crystal 'xtal').
>
> With the relevant asl
> Package () {"compatible", "maxim,max14830"},
> Package ()
> {"clock-frequency", 19200000},
> Package () {"clock-names", "osc"},
>
> Previously, the driver logic would default to 'xtal' and then compare
> against the narrower frequency range and throw an error because 19.2MHz
> was not allowed. With your patch, it proceeds as 'osc' and appears to
> work as intended.
Thanks for testing!
I assume I may convert above to the Tested-by: or equivalent tag.
JFYI, in OSS mailing lists we do not top post.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-07-23 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 15:02 [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL Andy Shevchenko
2021-07-22 15:45 ` Andy Shevchenko
2021-07-22 21:05 ` Dennis Giaya
2021-07-23 12:28 ` andriy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPq1+NzJeqLZVctW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dgiaya@whoi.edu \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).