linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Chris Down <chris@chrisdown.name>
Cc: kernel test robot <lkp@intel.com>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [printk:for-5.15-printk-index 4/5] kernel/printk/index.c:140:6: warning: no previous prototype for 'pi_create_file'
Date: Fri, 23 Jul 2021 13:19:47 +0200	[thread overview]
Message-ID: <YPql089IwSpudw/1@alley> (raw)
In-Reply-To: <YPa7WTw2rmYpI1uE@chrisdown.name>

On Tue 2021-07-20 13:02:33, Chris Down wrote:
> kernel test robot writes:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git for-5.15-printk-index
> > head:   ad7d61f159db73974f1b0352f21afe04b0bbd920
> > commit: 337015573718b161891a3473d25f59273f2e626b [4/5] printk: Userspace format indexing support
> > config: arc-allyesconfig (attached as .config)
> > compiler: arceb-elf-gcc (GCC) 10.3.0
> > reproduce (this is a W=1 build):
> >        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >        chmod +x ~/bin/make.cross
> >        # https://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git/commit/?id=337015573718b161891a3473d25f59273f2e626b
> >        git remote add printk https://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git
> >        git fetch --no-tags printk for-5.15-printk-index
> >        git checkout 337015573718b161891a3473d25f59273f2e626b
> >        # save the attached .config to linux build tree
> >        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arc
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > > > kernel/printk/index.c:140:6: warning: no previous prototype for 'pi_create_file' [-Wmissing-prototypes]
> >     140 | void pi_create_file(struct module *mod)
> >         |      ^~~~~~~~~~~~~~
> > > > kernel/printk/index.c:146:6: warning: no previous prototype for 'pi_remove_file' [-Wmissing-prototypes]
> >     146 | void pi_remove_file(struct module *mod)
> >         |      ^~~~~~~~~~~~~~
> 
> Ah, I missed `static inline', which causes the compiler to think we want to
> export it even though we don't.
> 
> diff --git kernel/printk/index.c kernel/printk/index.c
> index ca062f5e1779..e340e0a8b847 100644
> --- kernel/printk/index.c
> +++ kernel/printk/index.c
> @@ -137,13 +137,13 @@ static const char *pi_get_module_name(struct module *mod)
>  }
>  #endif
> -void pi_create_file(struct module *mod)
> +static inline void pi_create_file(struct module *mod)
>  {
>  	debugfs_create_file(pi_get_module_name(mod), 0444, dfs_index,
>  				       mod, &dfs_index_fops);
>  }
> -void pi_remove_file(struct module *mod)
> +static inline void pi_remove_file(struct module *mod)
>  {
>  	debugfs_remove(debugfs_lookup(pi_get_module_name(mod), dfs_index));
>  }

I have just pushed this fix into printk/linux.git,
branch for-5.15-printk-index.

Well, I just added the "static" keyword. Let the compiler decide
about inlining. There is no need to enforce it.

Best Regards,
Petr

      parent reply	other threads:[~2021-07-23 11:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 15:33 [printk:for-5.15-printk-index 4/5] kernel/printk/index.c:140:6: warning: no previous prototype for 'pi_create_file' kernel test robot
2021-07-20 12:02 ` Chris Down
2021-07-21  8:59   ` Petr Mladek
2021-07-23 11:19   ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPql089IwSpudw/1@alley \
    --to=pmladek@suse.com \
    --cc=chris@chrisdown.name \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).