linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral
@ 2021-05-12  6:14 satya priya
  2021-05-12  6:14 ` [PATCH V4 1/5] input: pm8941-pwrkey: add " satya priya
                   ` (5 more replies)
  0 siblings, 6 replies; 18+ messages in thread
From: satya priya @ 2021-05-12  6:14 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	Sebastian Reichel
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan, satya priya

David Collins (2):
  input: pm8941-pwrkey: add support for PMK8350 PON_HLOS PMIC peripheral
  dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings

satya priya (3):
  dt-bindings: power: reset: Change 'additionalProperties' to true
  dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to
    yaml
  dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml

 .../bindings/input/qcom,pm8941-pwrkey.txt          |  53 -----------
 .../bindings/input/qcom,pm8941-pwrkey.yaml         |  51 ++++++++++
 .../devicetree/bindings/power/reset/qcom,pon.txt   |  49 ----------
 .../devicetree/bindings/power/reset/qcom,pon.yaml  |  80 ++++++++++++++++
 .../bindings/power/reset/reboot-mode.yaml          |   2 +-
 drivers/input/misc/pm8941-pwrkey.c                 | 103 ++++++++++++++-------
 6 files changed, 204 insertions(+), 134 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
 delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
 create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH V4 1/5] input: pm8941-pwrkey: add support for PMK8350 PON_HLOS PMIC peripheral
  2021-05-12  6:14 [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya
@ 2021-05-12  6:14 ` satya priya
  2021-07-21 23:09   ` Stephen Boyd
  2021-05-12  6:14 ` [PATCH V4 2/5] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings satya priya
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 18+ messages in thread
From: satya priya @ 2021-05-12  6:14 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	Sebastian Reichel
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan, satya priya

From: David Collins <collinsd@codeaurora.org>

On Qualcomm Technologies, Inc. PMIC PMK8350, the PON peripheral
is split into two peripherals: PON_HLOS and PON_PBS.  The
application processor only has write access to PON_HLOS which
limits it to only receiving PON interrupts.

Add support for the PMK8350 PON_HLOS peripheral so that its
KPDPWR_N and RESIN_N interrupts can be used to detect key
presses.

Signed-off-by: David Collins <collinsd@codeaurora.org>
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Changes in V2:
 - No change.

Changes in V3:
 - No change.

Changes in V4:
 - No change.

 drivers/input/misc/pm8941-pwrkey.c | 103 ++++++++++++++++++++++++++-----------
 1 file changed, 72 insertions(+), 31 deletions(-)

diff --git a/drivers/input/misc/pm8941-pwrkey.c b/drivers/input/misc/pm8941-pwrkey.c
index cf81044..10e3fc0 100644
--- a/drivers/input/misc/pm8941-pwrkey.c
+++ b/drivers/input/misc/pm8941-pwrkey.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * Copyright (c) 2010-2011, Code Aurora Forum. All rights reserved.
+ * Copyright (c) 2010-2011, 2020-2021, The Linux Foundation. All rights reserved.
  * Copyright (c) 2014, Sony Mobile Communications Inc.
  */
 
@@ -22,6 +22,8 @@
 #define PON_RT_STS			0x10
 #define  PON_KPDPWR_N_SET		BIT(0)
 #define  PON_RESIN_N_SET		BIT(1)
+#define  PON_GEN3_RESIN_N_SET		BIT(6)
+#define  PON_GEN3_KPDPWR_N_SET		BIT(7)
 
 #define PON_PS_HOLD_RST_CTL		0x5a
 #define PON_PS_HOLD_RST_CTL2		0x5b
@@ -38,8 +40,12 @@
 #define  PON_DBC_DELAY_MASK		0x7
 
 struct pm8941_data {
-	unsigned int pull_up_bit;
-	unsigned int status_bit;
+	unsigned int	pull_up_bit;
+	unsigned int	status_bit;
+	bool		supports_ps_hold_poff_config;
+	bool		supports_debounce_config;
+	const char	*name;
+	const char	*phys;
 };
 
 struct pm8941_pwrkey {
@@ -231,34 +237,40 @@ static int pm8941_pwrkey_probe(struct platform_device *pdev)
 
 	input_set_capability(pwrkey->input, EV_KEY, pwrkey->code);
 
-	pwrkey->input->name = "pm8941_pwrkey";
-	pwrkey->input->phys = "pm8941_pwrkey/input0";
-
-	req_delay = (req_delay << 6) / USEC_PER_SEC;
-	req_delay = ilog2(req_delay);
-
-	error = regmap_update_bits(pwrkey->regmap,
-				   pwrkey->baseaddr + PON_DBC_CTL,
-				   PON_DBC_DELAY_MASK,
-				   req_delay);
-	if (error) {
-		dev_err(&pdev->dev, "failed to set debounce: %d\n", error);
-		return error;
+	pwrkey->input->name = pwrkey->data->name;
+	pwrkey->input->phys = pwrkey->data->phys;
+
+	if (pwrkey->data->supports_debounce_config) {
+		req_delay = (req_delay << 6) / USEC_PER_SEC;
+		req_delay = ilog2(req_delay);
+
+		error = regmap_update_bits(pwrkey->regmap,
+					   pwrkey->baseaddr + PON_DBC_CTL,
+					   PON_DBC_DELAY_MASK,
+					   req_delay);
+		if (error) {
+			dev_err(&pdev->dev, "failed to set debounce: %d\n",
+				error);
+			return error;
+		}
 	}
 
-	error = regmap_update_bits(pwrkey->regmap,
-				   pwrkey->baseaddr + PON_PULL_CTL,
-				   pwrkey->data->pull_up_bit,
-				   pull_up ? pwrkey->data->pull_up_bit : 0);
-	if (error) {
-		dev_err(&pdev->dev, "failed to set pull: %d\n", error);
-		return error;
+	if (pwrkey->data->pull_up_bit) {
+		error = regmap_update_bits(pwrkey->regmap,
+					   pwrkey->baseaddr + PON_PULL_CTL,
+					   pwrkey->data->pull_up_bit,
+					   pull_up ? pwrkey->data->pull_up_bit :
+						     0);
+		if (error) {
+			dev_err(&pdev->dev, "failed to set pull: %d\n", error);
+			return error;
+		}
 	}
 
 	error = devm_request_threaded_irq(&pdev->dev, pwrkey->irq,
 					  NULL, pm8941_pwrkey_irq,
 					  IRQF_ONESHOT,
-					  "pm8941_pwrkey", pwrkey);
+					  pwrkey->data->name, pwrkey);
 	if (error) {
 		dev_err(&pdev->dev, "failed requesting IRQ: %d\n", error);
 		return error;
@@ -271,12 +283,14 @@ static int pm8941_pwrkey_probe(struct platform_device *pdev)
 		return error;
 	}
 
-	pwrkey->reboot_notifier.notifier_call = pm8941_reboot_notify,
-	error = register_reboot_notifier(&pwrkey->reboot_notifier);
-	if (error) {
-		dev_err(&pdev->dev, "failed to register reboot notifier: %d\n",
-			error);
-		return error;
+	if (pwrkey->data->supports_ps_hold_poff_config) {
+		pwrkey->reboot_notifier.notifier_call = pm8941_reboot_notify,
+		error = register_reboot_notifier(&pwrkey->reboot_notifier);
+		if (error) {
+			dev_err(&pdev->dev, "failed to register reboot notifier: %d\n",
+				error);
+			return error;
+		}
 	}
 
 	platform_set_drvdata(pdev, pwrkey);
@@ -289,7 +303,8 @@ static int pm8941_pwrkey_remove(struct platform_device *pdev)
 {
 	struct pm8941_pwrkey *pwrkey = platform_get_drvdata(pdev);
 
-	unregister_reboot_notifier(&pwrkey->reboot_notifier);
+	if (pwrkey->data->supports_ps_hold_poff_config)
+		unregister_reboot_notifier(&pwrkey->reboot_notifier);
 
 	return 0;
 }
@@ -297,16 +312,42 @@ static int pm8941_pwrkey_remove(struct platform_device *pdev)
 static const struct pm8941_data pwrkey_data = {
 	.pull_up_bit = PON_KPDPWR_PULL_UP,
 	.status_bit = PON_KPDPWR_N_SET,
+	.name = "pm8941_pwrkey",
+	.phys = "pm8941_pwrkey/input0",
+	.supports_ps_hold_poff_config = true,
+	.supports_debounce_config = true,
 };
 
 static const struct pm8941_data resin_data = {
 	.pull_up_bit = PON_RESIN_PULL_UP,
 	.status_bit = PON_RESIN_N_SET,
+	.name = "pm8941_resin",
+	.phys = "pm8941_resin/input0",
+	.supports_ps_hold_poff_config = true,
+	.supports_debounce_config = true,
+};
+
+static const struct pm8941_data pon_gen3_pwrkey_data = {
+	.status_bit = PON_GEN3_KPDPWR_N_SET,
+	.name = "pmic_pwrkey",
+	.phys = "pmic_pwrkey/input0",
+	.supports_ps_hold_poff_config = false,
+	.supports_debounce_config = false,
+};
+
+static const struct pm8941_data pon_gen3_resin_data = {
+	.status_bit = PON_GEN3_RESIN_N_SET,
+	.name = "pmic_resin",
+	.phys = "pmic_resin/input0",
+	.supports_ps_hold_poff_config = false,
+	.supports_debounce_config = false,
 };
 
 static const struct of_device_id pm8941_pwr_key_id_table[] = {
 	{ .compatible = "qcom,pm8941-pwrkey", .data = &pwrkey_data },
 	{ .compatible = "qcom,pm8941-resin", .data = &resin_data },
+	{ .compatible = "qcom,pmk8350-pwrkey", .data = &pon_gen3_pwrkey_data },
+	{ .compatible = "qcom,pmk8350-resin", .data = &pon_gen3_resin_data },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, pm8941_pwr_key_id_table);
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH V4 2/5] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings
  2021-05-12  6:14 [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya
  2021-05-12  6:14 ` [PATCH V4 1/5] input: pm8941-pwrkey: add " satya priya
@ 2021-05-12  6:14 ` satya priya
  2021-07-21 23:10   ` Stephen Boyd
  2021-05-12  6:14 ` [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true satya priya
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 18+ messages in thread
From: satya priya @ 2021-05-12  6:14 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	Sebastian Reichel
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan, satya priya

From: David Collins <collinsd@codeaurora.org>

Add power key and resin compatible strings for the PMK8350 PMIC.
These are needed to distinguish key PON_HLOS register differences
between PMK8350 and previous PMIC PON modules.

Signed-off-by: David Collins <collinsd@codeaurora.org>
Signed-off-by: satya priya <skakit@codeaurora.org>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in V2:
 - Moved this patch before the conversion patches.

Changes in V3:
 - No changes.

Changes in V4:
 - No changes.

 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
index 34ab576..6cd08bc 100644
--- a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
+++ b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
@@ -8,6 +8,8 @@ PROPERTIES
 	Definition: must be one of:
 		    "qcom,pm8941-pwrkey"
 		    "qcom,pm8941-resin"
+		    "qcom,pmk8350-pwrkey"
+		    "qcom,pmk8350-resin"
 
 - reg:
 	Usage: required
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true
  2021-05-12  6:14 [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya
  2021-05-12  6:14 ` [PATCH V4 1/5] input: pm8941-pwrkey: add " satya priya
  2021-05-12  6:14 ` [PATCH V4 2/5] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings satya priya
@ 2021-05-12  6:14 ` satya priya
  2021-05-12  8:23   ` Sebastian Reichel
                     ` (2 more replies)
  2021-05-12  6:14 ` [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml satya priya
                   ` (2 subsequent siblings)
  5 siblings, 3 replies; 18+ messages in thread
From: satya priya @ 2021-05-12  6:14 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	Sebastian Reichel
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan, satya priya

Change 'additionalProperties' to true as this is a generic binding.

Signed-off-by: satya priya <skakit@codeaurora.org>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in V3:
 - This is newly added in V3.

Changes in V4:
 - No Changes.

 Documentation/devicetree/bindings/power/reset/reboot-mode.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
index 9c6fda6..ad0a0b9 100644
--- a/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
+++ b/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
@@ -36,7 +36,7 @@ patternProperties:
   "^mode-.*$":
     $ref: /schemas/types.yaml#/definitions/uint32
 
-additionalProperties: false
+additionalProperties: true
 
 examples:
   - |
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml
  2021-05-12  6:14 [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya
                   ` (2 preceding siblings ...)
  2021-05-12  6:14 ` [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true satya priya
@ 2021-05-12  6:14 ` satya priya
  2021-05-18  0:49   ` Rob Herring
                     ` (2 more replies)
  2021-05-12  6:14 ` [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON " satya priya
  2021-07-13  3:57 ` [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral skakit
  5 siblings, 3 replies; 18+ messages in thread
From: satya priya @ 2021-05-12  6:14 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	Sebastian Reichel
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan, satya priya

Convert qcom pm8941 power key binding from .txt to .yaml format.

The example has been removed in favour of full example being
available in the qcom,pon.yaml binding.

Signed-off-by: satya priya <skakit@codeaurora.org>
---
Changes in V2:
 - Fixed bot errors, took reference from input.yaml for "linux,code"
 - Added one complete example for powerkey and resin, and referenced it
   in main PON binding.
 - Moved this patch to the end of the series.

Changes in V3:
 - Moved this patch before PON binding patch.
 - As per Rob's comments, added allOf at the beginning of binding.
   Added maxItems for interrupts.
 - Added 'unevaluatedProperties' instead of 'additionalProperties' as
   we are using allOf.

Changes in V4:
 - Removed the example and added in qcom,pon.yaml

 .../bindings/input/qcom,pm8941-pwrkey.txt          | 55 ----------------------
 .../bindings/input/qcom,pm8941-pwrkey.yaml         | 51 ++++++++++++++++++++
 2 files changed, 51 insertions(+), 55 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
 create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml

diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
deleted file mode 100644
index 6cd08bc..0000000
--- a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
+++ /dev/null
@@ -1,55 +0,0 @@
-Qualcomm PM8941 PMIC Power Key
-
-PROPERTIES
-
-- compatible:
-	Usage: required
-	Value type: <string>
-	Definition: must be one of:
-		    "qcom,pm8941-pwrkey"
-		    "qcom,pm8941-resin"
-		    "qcom,pmk8350-pwrkey"
-		    "qcom,pmk8350-resin"
-
-- reg:
-	Usage: required
-	Value type: <prop-encoded-array>
-	Definition: base address of registers for block
-
-- interrupts:
-	Usage: required
-	Value type: <prop-encoded-array>
-	Definition: key change interrupt; The format of the specifier is
-		    defined by the binding document describing the node's
-		    interrupt parent.
-
-- debounce:
-	Usage: optional
-	Value type: <u32>
-	Definition: time in microseconds that key must be pressed or released
-		    for state change interrupt to trigger.
-
-- bias-pull-up:
-	Usage: optional
-	Value type: <empty>
-	Definition: presence of this property indicates that the KPDPWR_N pin
-		    should be configured for pull up.
-
-- linux,code:
-	Usage: optional
-	Value type: <u32>
-	Definition: The input key-code associated with the power key.
-		    Use the linux event codes defined in
-		    include/dt-bindings/input/linux-event-codes.h
-		    When property is omitted KEY_POWER is assumed.
-
-EXAMPLE
-
-	pwrkey@800 {
-		compatible = "qcom,pm8941-pwrkey";
-		reg = <0x800>;
-		interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
-		debounce = <15625>;
-		bias-pull-up;
-		linux,code = <KEY_POWER>;
-	};
diff --git a/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
new file mode 100644
index 0000000..62314a5
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/qcom,pm8941-pwrkey.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PM8941 PMIC Power Key
+
+maintainers:
+  - Courtney Cavin <courtney.cavin@sonymobile.com>
+  - Vinod Koul <vkoul@kernel.org>
+
+allOf:
+  - $ref: input.yaml#
+
+properties:
+  compatible:
+    enum:
+      - qcom,pm8941-pwrkey
+      - qcom,pm8941-resin
+      - qcom,pmk8350-pwrkey
+      - qcom,pmk8350-resin
+
+  interrupts:
+    maxItems: 1
+
+  debounce:
+    description: |
+          Time in microseconds that key must be pressed or
+          released for state change interrupt to trigger.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+  bias-pull-up:
+    description: |
+           Presence of this property indicates that the KPDPWR_N
+           pin should be configured for pull up.
+    $ref: /schemas/types.yaml#/definitions/flag
+
+  linux,code:
+    description: |
+           The input key-code associated with the power key.
+           Use the linux event codes defined in
+           include/dt-bindings/input/linux-event-codes.h
+           When property is omitted KEY_POWER is assumed.
+
+required:
+  - compatible
+  - interrupts
+
+unevaluatedProperties: false
+...
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml
  2021-05-12  6:14 [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya
                   ` (3 preceding siblings ...)
  2021-05-12  6:14 ` [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml satya priya
@ 2021-05-12  6:14 ` satya priya
  2021-05-12  8:24   ` Sebastian Reichel
                     ` (2 more replies)
  2021-07-13  3:57 ` [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral skakit
  5 siblings, 3 replies; 18+ messages in thread
From: satya priya @ 2021-05-12  6:14 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	Sebastian Reichel
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan, satya priya

Convert qcom PON binding from .txt to .yaml format.

Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes in V2:
 - As per Rob's comments, converted the main PON binding and added in V2.
   Dropped example here to have one full example in qcom,pm8941-pwrkey.yaml

Changes in V3:
 - As per Sebastian's comments, added allOf to refer reboot-mode.yaml and
   used unevaluatedProperties = false. Added maxItems for reg.

Changes in V4:
 - Added the example back. Removed it in qcom,pm8941-pwrkey.yaml

 .../devicetree/bindings/power/reset/qcom,pon.txt   | 49 -------------
 .../devicetree/bindings/power/reset/qcom,pon.yaml  | 80 ++++++++++++++++++++++
 2 files changed, 80 insertions(+), 49 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
 create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml

diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt
deleted file mode 100644
index 0c0dc3a..0000000
--- a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt
+++ /dev/null
@@ -1,49 +0,0 @@
-Qualcomm PON Device
-
-The Power On device for Qualcomm PM8xxx is MFD supporting pwrkey
-and resin along with the Android reboot-mode.
-
-This DT node has pwrkey and resin as sub nodes.
-
-Required Properties:
--compatible: Must be one of:
-	"qcom,pm8916-pon"
-	"qcom,pms405-pon"
-	"qcom,pm8998-pon"
-
--reg: Specifies the physical address of the pon register
-
-Optional subnode:
--pwrkey: Specifies the subnode pwrkey and should follow the
- qcom,pm8941-pwrkey.txt description.
--resin: Specifies the subnode resin and should follow the
- qcom,pm8xxx-pwrkey.txt description.
-
-The rest of the properties should follow the generic reboot-mode description
-found in reboot-mode.txt
-
-Example:
-
-	pon@800 {
-		compatible = "qcom,pm8916-pon";
-
-		reg = <0x800>;
-		mode-bootloader = <0x2>;
-		mode-recovery = <0x1>;
-
-		pwrkey {
-			compatible = "qcom,pm8941-pwrkey";
-			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
-			debounce = <15625>;
-			bias-pull-up;
-			linux,code = <KEY_POWER>;
-		};
-
-		resin {
-			compatible = "qcom,pm8941-resin";
-			interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
-			debounce = <15625>;
-			bias-pull-up;
-			linux,code = <KEY_VOLUMEDOWN>;
-		};
-	};
diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
new file mode 100644
index 0000000..353f155
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/reset/qcom,pon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PON Device
+
+maintainers:
+  - Vinod Koul <vkoul@kernel.org>
+
+description: |
+  The Power On device for Qualcomm PM8xxx is MFD supporting pwrkey
+  and resin along with the Android reboot-mode.
+
+  This DT node has pwrkey and resin as sub nodes.
+
+allOf:
+  - $ref: reboot-mode.yaml#
+
+properties:
+  compatible:
+    enum:
+      - qcom,pm8916-pon
+      - qcom,pms405-pon
+      - qcom,pm8998-pon
+
+  reg:
+    maxItems: 1
+
+  pwrkey:
+    type: object
+    $ref: "../../input/qcom,pm8941-pwrkey.yaml#"
+
+  resin:
+    type: object
+    $ref: "../../input/qcom,pm8941-pwrkey.yaml#"
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+   #include <dt-bindings/interrupt-controller/irq.h>
+   #include <dt-bindings/input/linux-event-codes.h>
+   #include <dt-bindings/spmi/spmi.h>
+   spmi_bus: spmi@c440000 {
+     reg = <0x0c440000 0x1100>;
+     #address-cells = <2>;
+     #size-cells = <0>;
+     pmk8350: pmic@0 {
+       reg = <0x0 SPMI_USID>;
+       #address-cells = <1>;
+       #size-cells = <0>;
+       pmk8350_pon: pon_hlos@1300 {
+         reg = <0x1300>;
+         compatible = "qcom,pm8998-pon";
+
+         pwrkey {
+            compatible = "qcom,pm8941-pwrkey";
+            interrupts = < 0x0 0x8 0 IRQ_TYPE_EDGE_BOTH >;
+            debounce = <15625>;
+            bias-pull-up;
+            linux,code = <KEY_POWER>;
+         };
+
+         resin {
+            compatible = "qcom,pm8941-resin";
+            interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
+            debounce = <15625>;
+            bias-pull-up;
+            linux,code = <KEY_VOLUMEDOWN>;
+         };
+       };
+     };
+   };
+...
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true
  2021-05-12  6:14 ` [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true satya priya
@ 2021-05-12  8:23   ` Sebastian Reichel
  2021-07-21 23:11   ` Stephen Boyd
  2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Sebastian Reichel @ 2021-05-12  8:23 UTC (permalink / raw)
  To: satya priya
  Cc: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

Hi,

On Wed, May 12, 2021 at 11:44:11AM +0530, satya priya wrote:
> Change 'additionalProperties' to true as this is a generic binding.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> Changes in V3:
>  - This is newly added in V3.
> 
> Changes in V4:
>  - No Changes.
> 
>  Documentation/devicetree/bindings/power/reset/reboot-mode.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
> index 9c6fda6..ad0a0b9 100644
> --- a/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/reboot-mode.yaml
> @@ -36,7 +36,7 @@ patternProperties:
>    "^mode-.*$":
>      $ref: /schemas/types.yaml#/definitions/uint32
>  
> -additionalProperties: false
> +additionalProperties: true
>  
>  examples:
>    - |
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
> of Code Aurora Forum, hosted by The Linux Foundation
> 

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml
  2021-05-12  6:14 ` [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON " satya priya
@ 2021-05-12  8:24   ` Sebastian Reichel
  2021-07-21 23:12   ` Stephen Boyd
  2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Sebastian Reichel @ 2021-05-12  8:24 UTC (permalink / raw)
  To: satya priya
  Cc: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

[-- Attachment #1: Type: text/plain, Size: 5327 bytes --]

Hi,

On Wed, May 12, 2021 at 11:44:13AM +0530, satya priya wrote:
> Convert qcom PON binding from .txt to .yaml format.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> Changes in V2:
>  - As per Rob's comments, converted the main PON binding and added in V2.
>    Dropped example here to have one full example in qcom,pm8941-pwrkey.yaml
> 
> Changes in V3:
>  - As per Sebastian's comments, added allOf to refer reboot-mode.yaml and
>    used unevaluatedProperties = false. Added maxItems for reg.
> 
> Changes in V4:
>  - Added the example back. Removed it in qcom,pm8941-pwrkey.yaml
> 
>  .../devicetree/bindings/power/reset/qcom,pon.txt   | 49 -------------
>  .../devicetree/bindings/power/reset/qcom,pon.yaml  | 80 ++++++++++++++++++++++
>  2 files changed, 80 insertions(+), 49 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
>  create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt
> deleted file mode 100644
> index 0c0dc3a..0000000
> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt
> +++ /dev/null
> @@ -1,49 +0,0 @@
> -Qualcomm PON Device
> -
> -The Power On device for Qualcomm PM8xxx is MFD supporting pwrkey
> -and resin along with the Android reboot-mode.
> -
> -This DT node has pwrkey and resin as sub nodes.
> -
> -Required Properties:
> --compatible: Must be one of:
> -	"qcom,pm8916-pon"
> -	"qcom,pms405-pon"
> -	"qcom,pm8998-pon"
> -
> --reg: Specifies the physical address of the pon register
> -
> -Optional subnode:
> --pwrkey: Specifies the subnode pwrkey and should follow the
> - qcom,pm8941-pwrkey.txt description.
> --resin: Specifies the subnode resin and should follow the
> - qcom,pm8xxx-pwrkey.txt description.
> -
> -The rest of the properties should follow the generic reboot-mode description
> -found in reboot-mode.txt
> -
> -Example:
> -
> -	pon@800 {
> -		compatible = "qcom,pm8916-pon";
> -
> -		reg = <0x800>;
> -		mode-bootloader = <0x2>;
> -		mode-recovery = <0x1>;
> -
> -		pwrkey {
> -			compatible = "qcom,pm8941-pwrkey";
> -			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> -			debounce = <15625>;
> -			bias-pull-up;
> -			linux,code = <KEY_POWER>;
> -		};
> -
> -		resin {
> -			compatible = "qcom,pm8941-resin";
> -			interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> -			debounce = <15625>;
> -			bias-pull-up;
> -			linux,code = <KEY_VOLUMEDOWN>;
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> new file mode 100644
> index 0000000..353f155
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/qcom,pon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm PON Device
> +
> +maintainers:
> +  - Vinod Koul <vkoul@kernel.org>
> +
> +description: |
> +  The Power On device for Qualcomm PM8xxx is MFD supporting pwrkey
> +  and resin along with the Android reboot-mode.
> +
> +  This DT node has pwrkey and resin as sub nodes.
> +
> +allOf:
> +  - $ref: reboot-mode.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,pm8916-pon
> +      - qcom,pms405-pon
> +      - qcom,pm8998-pon
> +
> +  reg:
> +    maxItems: 1
> +
> +  pwrkey:
> +    type: object
> +    $ref: "../../input/qcom,pm8941-pwrkey.yaml#"
> +
> +  resin:
> +    type: object
> +    $ref: "../../input/qcom,pm8941-pwrkey.yaml#"
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +   #include <dt-bindings/interrupt-controller/irq.h>
> +   #include <dt-bindings/input/linux-event-codes.h>
> +   #include <dt-bindings/spmi/spmi.h>
> +   spmi_bus: spmi@c440000 {
> +     reg = <0x0c440000 0x1100>;
> +     #address-cells = <2>;
> +     #size-cells = <0>;
> +     pmk8350: pmic@0 {
> +       reg = <0x0 SPMI_USID>;
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +       pmk8350_pon: pon_hlos@1300 {
> +         reg = <0x1300>;
> +         compatible = "qcom,pm8998-pon";
> +
> +         pwrkey {
> +            compatible = "qcom,pm8941-pwrkey";
> +            interrupts = < 0x0 0x8 0 IRQ_TYPE_EDGE_BOTH >;
> +            debounce = <15625>;
> +            bias-pull-up;
> +            linux,code = <KEY_POWER>;
> +         };
> +
> +         resin {
> +            compatible = "qcom,pm8941-resin";
> +            interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
> +            debounce = <15625>;
> +            bias-pull-up;
> +            linux,code = <KEY_VOLUMEDOWN>;
> +         };
> +       };
> +     };
> +   };
> +...
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
> of Code Aurora Forum, hosted by The Linux Foundation
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml
  2021-05-12  6:14 ` [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml satya priya
@ 2021-05-18  0:49   ` Rob Herring
  2021-07-21 23:12   ` Stephen Boyd
  2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Rob Herring @ 2021-05-18  0:49 UTC (permalink / raw)
  To: satya priya
  Cc: Vinod Koul, devicetree, linux-pm, David Collins,
	Sebastian Reichel, linux-input, linux-arm-msm, Bjorn Andersson,
	Rob Herring, kgunda, linux-kernel, Andy Gross, Dmitry Torokhov,
	Andy Yan

On Wed, 12 May 2021 11:44:12 +0530, satya priya wrote:
> Convert qcom pm8941 power key binding from .txt to .yaml format.
> 
> The example has been removed in favour of full example being
> available in the qcom,pon.yaml binding.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V2:
>  - Fixed bot errors, took reference from input.yaml for "linux,code"
>  - Added one complete example for powerkey and resin, and referenced it
>    in main PON binding.
>  - Moved this patch to the end of the series.
> 
> Changes in V3:
>  - Moved this patch before PON binding patch.
>  - As per Rob's comments, added allOf at the beginning of binding.
>    Added maxItems for interrupts.
>  - Added 'unevaluatedProperties' instead of 'additionalProperties' as
>    we are using allOf.
> 
> Changes in V4:
>  - Removed the example and added in qcom,pon.yaml
> 
>  .../bindings/input/qcom,pm8941-pwrkey.txt          | 55 ----------------------
>  .../bindings/input/qcom,pm8941-pwrkey.yaml         | 51 ++++++++++++++++++++
>  2 files changed, 51 insertions(+), 55 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
>  create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral
  2021-05-12  6:14 [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya
                   ` (4 preceding siblings ...)
  2021-05-12  6:14 ` [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON " satya priya
@ 2021-07-13  3:57 ` skakit
  5 siblings, 0 replies; 18+ messages in thread
From: skakit @ 2021-07-13  3:57 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Andy Gross, Bjorn Andersson,
	Sebastian Reichel
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

Hi Dmitry,

On 2021-05-12 11:44, satya priya wrote:
> David Collins (2):
>   input: pm8941-pwrkey: add support for PMK8350 PON_HLOS PMIC 
> peripheral
>   dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings
> 


> satya priya (3):
>   dt-bindings: power: reset: Change 'additionalProperties' to true
>   dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding 
> to
>     yaml
>   dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml
> 
Could you please pick these 3 patches.

Thanks,
Satya Priya
>  .../bindings/input/qcom,pm8941-pwrkey.txt          |  53 -----------
>  .../bindings/input/qcom,pm8941-pwrkey.yaml         |  51 ++++++++++
>  .../devicetree/bindings/power/reset/qcom,pon.txt   |  49 ----------
>  .../devicetree/bindings/power/reset/qcom,pon.yaml  |  80 
> ++++++++++++++++
>  .../bindings/power/reset/reboot-mode.yaml          |   2 +-
>  drivers/input/misc/pm8941-pwrkey.c                 | 103 
> ++++++++++++++-------
>  6 files changed, 204 insertions(+), 134 deletions(-)
>  delete mode 100644
> Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.txt
>  create mode 100644
> Documentation/devicetree/bindings/input/qcom,pm8941-pwrkey.yaml
>  delete mode 100644 
> Documentation/devicetree/bindings/power/reset/qcom,pon.txt
>  create mode 100644 
> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 1/5] input: pm8941-pwrkey: add support for PMK8350 PON_HLOS PMIC peripheral
  2021-05-12  6:14 ` [PATCH V4 1/5] input: pm8941-pwrkey: add " satya priya
@ 2021-07-21 23:09   ` Stephen Boyd
  0 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2021-07-21 23:09 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Dmitry Torokhov, Rob Herring,
	Sebastian Reichel, satya priya
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

Quoting satya priya (2021-05-11 23:14:09)
> From: David Collins <collinsd@codeaurora.org>
>
> On Qualcomm Technologies, Inc. PMIC PMK8350, the PON peripheral
> is split into two peripherals: PON_HLOS and PON_PBS.  The
> application processor only has write access to PON_HLOS which
> limits it to only receiving PON interrupts.
>
> Add support for the PMK8350 PON_HLOS peripheral so that its
> KPDPWR_N and RESIN_N interrupts can be used to detect key
> presses.
>
> Signed-off-by: David Collins <collinsd@codeaurora.org>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 2/5] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings
  2021-05-12  6:14 ` [PATCH V4 2/5] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings satya priya
@ 2021-07-21 23:10   ` Stephen Boyd
  0 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2021-07-21 23:10 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Dmitry Torokhov, Rob Herring,
	Sebastian Reichel, satya priya
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

Quoting satya priya (2021-05-11 23:14:10)
> From: David Collins <collinsd@codeaurora.org>
>
> Add power key and resin compatible strings for the PMK8350 PMIC.
> These are needed to distinguish key PON_HLOS register differences
> between PMK8350 and previous PMIC PON modules.
>
> Signed-off-by: David Collins <collinsd@codeaurora.org>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true
  2021-05-12  6:14 ` [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true satya priya
  2021-05-12  8:23   ` Sebastian Reichel
@ 2021-07-21 23:11   ` Stephen Boyd
  2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2021-07-21 23:11 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Dmitry Torokhov, Rob Herring,
	Sebastian Reichel, satya priya
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

Quoting satya priya (2021-05-11 23:14:11)
> Change 'additionalProperties' to true as this is a generic binding.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml
  2021-05-12  6:14 ` [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml satya priya
  2021-05-18  0:49   ` Rob Herring
@ 2021-07-21 23:12   ` Stephen Boyd
  2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2021-07-21 23:12 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Dmitry Torokhov, Rob Herring,
	Sebastian Reichel, satya priya
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

Quoting satya priya (2021-05-11 23:14:12)
> Convert qcom pm8941 power key binding from .txt to .yaml format.
>
> The example has been removed in favour of full example being
> available in the qcom,pon.yaml binding.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml
  2021-05-12  6:14 ` [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON " satya priya
  2021-05-12  8:24   ` Sebastian Reichel
@ 2021-07-21 23:12   ` Stephen Boyd
  2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Stephen Boyd @ 2021-07-21 23:12 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Dmitry Torokhov, Rob Herring,
	Sebastian Reichel, satya priya
  Cc: David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

Quoting satya priya (2021-05-11 23:14:13)
> Convert qcom PON binding from .txt to .yaml format.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true
  2021-05-12  6:14 ` [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true satya priya
  2021-05-12  8:23   ` Sebastian Reichel
  2021-07-21 23:11   ` Stephen Boyd
@ 2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Dmitry Torokhov @ 2021-07-23 19:37 UTC (permalink / raw)
  To: satya priya
  Cc: Rob Herring, Andy Gross, Bjorn Andersson, Sebastian Reichel,
	David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

On Wed, May 12, 2021 at 11:44:11AM +0530, satya priya wrote:
> Change 'additionalProperties' to true as this is a generic binding.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Acked-by: Rob Herring <robh@kernel.org>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml
  2021-05-12  6:14 ` [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml satya priya
  2021-05-18  0:49   ` Rob Herring
  2021-07-21 23:12   ` Stephen Boyd
@ 2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Dmitry Torokhov @ 2021-07-23 19:37 UTC (permalink / raw)
  To: satya priya
  Cc: Rob Herring, Andy Gross, Bjorn Andersson, Sebastian Reichel,
	David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

On Wed, May 12, 2021 at 11:44:12AM +0530, satya priya wrote:
> Convert qcom pm8941 power key binding from .txt to .yaml format.
> 
> The example has been removed in favour of full example being
> available in the qcom,pon.yaml binding.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml
  2021-05-12  6:14 ` [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON " satya priya
  2021-05-12  8:24   ` Sebastian Reichel
  2021-07-21 23:12   ` Stephen Boyd
@ 2021-07-23 19:37   ` Dmitry Torokhov
  2 siblings, 0 replies; 18+ messages in thread
From: Dmitry Torokhov @ 2021-07-23 19:37 UTC (permalink / raw)
  To: satya priya
  Cc: Rob Herring, Andy Gross, Bjorn Andersson, Sebastian Reichel,
	David Collins, kgunda, linux-input, linux-pm, linux-kernel,
	devicetree, linux-arm-msm, Vinod Koul, Andy Yan

On Wed, May 12, 2021 at 11:44:13AM +0530, satya priya wrote:
> Convert qcom PON binding from .txt to .yaml format.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2021-07-23 19:37 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12  6:14 [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral satya priya
2021-05-12  6:14 ` [PATCH V4 1/5] input: pm8941-pwrkey: add " satya priya
2021-07-21 23:09   ` Stephen Boyd
2021-05-12  6:14 ` [PATCH V4 2/5] dt-bindings: input: pm8941-pwrkey: add pmk8350 compatible strings satya priya
2021-07-21 23:10   ` Stephen Boyd
2021-05-12  6:14 ` [PATCH V4 3/5] dt-bindings: power: reset: Change 'additionalProperties' to true satya priya
2021-05-12  8:23   ` Sebastian Reichel
2021-07-21 23:11   ` Stephen Boyd
2021-07-23 19:37   ` Dmitry Torokhov
2021-05-12  6:14 ` [PATCH V4 4/5] dt-bindings: input: pm8941-pwrkey: Convert pm8941 power key binding to yaml satya priya
2021-05-18  0:49   ` Rob Herring
2021-07-21 23:12   ` Stephen Boyd
2021-07-23 19:37   ` Dmitry Torokhov
2021-05-12  6:14 ` [PATCH V4 5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON " satya priya
2021-05-12  8:24   ` Sebastian Reichel
2021-07-21 23:12   ` Stephen Boyd
2021-07-23 19:37   ` Dmitry Torokhov
2021-07-13  3:57 ` [PATCH V4 0/5] Add support for PMK8350 PON_HLOS PMIC peripheral skakit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).