linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Luo Jie <luoj@codeaurora.org>
Cc: hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org,
	linux@armlinux.org.uk, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH v1 1/2] net: mdio: Add the reset function for IPQ MDIO driver
Date: Sun, 8 Aug 2021 17:29:44 +0200	[thread overview]
Message-ID: <YQ/4aK3yYPvYQdhD@lunn.ch> (raw)
In-Reply-To: <20210808072111.8365-2-luoj@codeaurora.org>

> +	/* Configure MDIO clock source frequency if clock is specified in the device tree */
> +	if (!IS_ERR_OR_NULL(priv->mdio_clk)) {

Please document the clock in the binding. Make it clear which devices
require the clock, and which don't.

	Andrew

  parent reply	other threads:[~2021-08-08 15:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  7:21 [PATCH v1 0/2] net: mdio: Add IPQ MDIO reset related function Luo Jie
2021-08-08  7:21 ` [PATCH v1 1/2] net: mdio: Add the reset function for IPQ MDIO driver Luo Jie
2021-08-08 15:27   ` Andrew Lunn
2021-08-09 13:01     ` Jie Luo
2021-08-08 15:29   ` Andrew Lunn [this message]
2021-08-09 13:02     ` Jie Luo
2021-08-08  7:21 ` [PATCH v1 2/2] MDIO: Kconfig: Specify more IPQ chipset supported Luo Jie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQ/4aK3yYPvYQdhD@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luoj@codeaurora.org \
    --cc=netdev@vger.kernel.org \
    --cc=sricharan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).