From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612FDC432BE for ; Fri, 6 Aug 2021 15:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D15860F70 for ; Fri, 6 Aug 2021 15:29:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244667AbhHFP3s (ORCPT ); Fri, 6 Aug 2021 11:29:48 -0400 Received: from mga14.intel.com ([192.55.52.115]:22818 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242735AbhHFP3r (ORCPT ); Fri, 6 Aug 2021 11:29:47 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10068"; a="214119746" X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="214119746" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 08:29:30 -0700 X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="513477110" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 08:29:29 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mC1ml-0067Lj-Qj; Fri, 06 Aug 2021 18:29:23 +0300 Date: Fri, 6 Aug 2021 18:29:23 +0300 From: Andy Shevchenko To: Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] dmaengine: acpi: Check for errors from acpi_register_gsi() separately Message-ID: References: <20210802175532.54311-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06, 2021 at 07:14:50PM +0530, Vinod Koul wrote: > On 02-08-21, 20:55, Andy Shevchenko wrote: > > While IRQ test agaist the returned variable in practice is a good enough > > there is still a room for theoretical mistake in case the vIRQ of the > > device contains the same error code that acpi_register_gsi() may return. > > Due to this, check for error code separately from matching the vIRQs. > > > > Besides that, append documentation to tell why acpi_gsi_to_irq() can't > > be used and we call acpi_register_gsi() instead. > > patch fails to apply, pls rebase I don't see that you applied the previous patch [1]. Care to apply it, please? [1]: https://lore.kernel.org/dmaengine/20210730202715.24375-1-andriy.shevchenko@linux.intel.com/T/#u -- With Best Regards, Andy Shevchenko