From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E62C4338F for ; Tue, 27 Jul 2021 17:17:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9529F61006 for ; Tue, 27 Jul 2021 17:17:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230047AbhG0RRZ (ORCPT ); Tue, 27 Jul 2021 13:17:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:33390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbhG0RRY (ORCPT ); Tue, 27 Jul 2021 13:17:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7630560FEE; Tue, 27 Jul 2021 17:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627406244; bh=BFC7TqihRIQPk6jsa0tydoz7BsGJuFoq0xn43KgBiEQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CO87DMlnYPPfeSPoUeELhrZWoMrOYJOFABPcipLb/mB9908DIqQXHCqjQzZ15KNfY Ar/YGZof9JpEzmeKJ+EidiH1r3snXpnqBmh2ZB0FuNK3BuSUjo3+sVdtxBz0WC2SaD jkb0qNcKYq92w5oj6+QIAKE80xDeetBk3nQogVUBUeekI8IJBmB6WF99wNMFQ1tw0Q m/7UFU3fNFpRDmkMhb7H5nYRL5NcSAqqJlB8S0m1AbzNfiD/ikPMV/TInv06Lg9Ln4 AIPbnvT9VFeF9FbWPYAfdcpxZIzWUWElJFAUvcUYrX3bNdf+DkqXElceWVKoR8gsRT 7kHhfbL64boMQ== Date: Tue, 27 Jul 2021 10:17:22 -0700 From: Jaegeuk Kim To: Chao Yu Cc: Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong , Eric Biggers Subject: Re: [f2fs-dev] [PATCH v4] f2fs: change fiemap way in printing compression chunk Message-ID: References: <20210726041819.2059593-1-daeho43@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27, Chao Yu wrote: > On 2021/7/26 12:18, Daeho Jeong wrote: > > From: Daeho Jeong > > > > When we print out a discontinuous compression chunk, it shows like a > > continuous chunk now. To show it more correctly, I've changed the way of > > printing fiemap info like below. Plus, eliminated NEW_ADDR(-1) in fiemap > > info, since it is not in fiemap user api manual. > > > > Let's assume 16KB compression cluster. > > > > > > Logical Physical Length Flags > > 0: 0000000000000000 00000002c091f000 0000000000004000 1008 > > 1: 0000000000004000 00000002c0920000 0000000000004000 1008 > > ... > > 9: 0000000000034000 0000000f8c623000 0000000000004000 1008 > > 10: 0000000000038000 000000101a6eb000 0000000000004000 1008 > > > > > > 0: 0000000000000000 00000002c091f000 0000000000004000 1008 > > 1: 0000000000004000 00000002c0920000 0000000000004000 1008 > > ... > > 9: 0000000000034000 0000000f8c623000 0000000000001000 1008 > > 10: 0000000000035000 000000101a6ea000 0000000000003000 1008 > > 11: 0000000000038000 000000101a6eb000 0000000000002000 1008 > > 12: 000000000003a000 00000002c3544000 0000000000002000 1008 > > > > Flags > > 0x1000 => FIEMAP_EXTENT_MERGED > > 0x0008 => FIEMAP_EXTENT_ENCODED > > > > Signed-off-by: Daeho Jeong > > Tested-by: Eric Biggers > > > > --- > > v4: initialized count_in_cluster > > v3: fix the missing last extent flag issue > > v2: changed the print format > > --- > > fs/f2fs/data.c | 75 ++++++++++++++++++++++++++++---------------------- > > 1 file changed, 42 insertions(+), 33 deletions(-) > > > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > > index 3a01a1b50104..1a716c3b5457 100644 > > --- a/fs/f2fs/data.c > > +++ b/fs/f2fs/data.c > > @@ -1843,8 +1843,9 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > > u64 logical = 0, phys = 0, size = 0; > > u32 flags = 0; > > int ret = 0; > > - bool compr_cluster = false; > > + bool compr_cluster = false, compr_appended; > > unsigned int cluster_size = F2FS_I(inode)->i_cluster_size; > > + unsigned int count_in_cluster = 0; > > loff_t maxbytes; > > if (fieinfo->fi_flags & FIEMAP_FLAG_CACHE) { > > @@ -1892,15 +1893,17 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > > map.m_next_pgofs = &next_pgofs; > > map.m_seg_type = NO_CHECK_TYPE; > > - if (compr_cluster) > > - map.m_len = cluster_size - 1; > > + if (compr_cluster) { > > + map.m_lblk += 1; > > + map.m_len = cluster_size - count_in_cluster; > > + } > > ret = f2fs_map_blocks(inode, &map, 0, F2FS_GET_BLOCK_FIEMAP); > > if (ret) > > goto out; > > /* HOLE */ > > - if (!(map.m_flags & F2FS_MAP_FLAGS)) { > > + if (!compr_cluster && !(map.m_flags & F2FS_MAP_FLAGS)) { > > start_blk = next_pgofs; > > if (blks_to_bytes(inode, start_blk) < blks_to_bytes(inode, > > @@ -1910,6 +1913,14 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > > flags |= FIEMAP_EXTENT_LAST; > > } > > + compr_appended = false; > > + /* In a case of compressed cluster, append this to the last extent */ > > + if (compr_cluster && ((map.m_flags & F2FS_MAP_UNWRITTEN) || > > + !(map.m_flags & F2FS_MAP_FLAGS))) { > > + compr_appended = true; > > + goto skip_fill; > > + } > > + > > if (size) { > > flags |= FIEMAP_EXTENT_MERGED; > > if (IS_ENCRYPTED(inode)) > > @@ -1926,38 +1937,36 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > > if (start_blk > last_blk) > > goto out; > > - if (compr_cluster) { > > - compr_cluster = false; > > - > > - > > - logical = blks_to_bytes(inode, start_blk - 1); > > - phys = blks_to_bytes(inode, map.m_pblk); > > - size = blks_to_bytes(inode, cluster_size); > > - > > - flags |= FIEMAP_EXTENT_ENCODED; > > - > > - start_blk += cluster_size - 1; > > - > > - if (start_blk > last_blk) > > - goto out; > > - > > - goto prep_next; > > - } > > - > > +skip_fill: > > if (map.m_pblk == COMPRESS_ADDR) { > > Looks good, but one more thing I concern is how about detecting and > returning -EFSCORRUPTED for below corrupted metadata cases: > - [COMPRESS_ADDR, blkaddr, COMPRESS_ADDR, NEW_ADDR] > - [blkaddr, COMPRESS_ADDR, NULL_ADDR, NULL_ADDR] Do we really need to catch this in fiemap? What about giving the current layout with warning message and setting NEED_FSCK? > > Thanks, > > > compr_cluster = true; > > - start_blk++; > > - goto prep_next; > > - } > > - > > - logical = blks_to_bytes(inode, start_blk); > > - phys = blks_to_bytes(inode, map.m_pblk); > > - size = blks_to_bytes(inode, map.m_len); > > - flags = 0; > > - if (map.m_flags & F2FS_MAP_UNWRITTEN) > > - flags = FIEMAP_EXTENT_UNWRITTEN; > > + count_in_cluster = 1; > > + } else if (compr_appended) { > > + unsigned int appended_blks = cluster_size - > > + count_in_cluster + 1; > > + size += blks_to_bytes(inode, appended_blks); > > + start_blk += appended_blks; > > + compr_cluster = false; > > + } else { > > + logical = blks_to_bytes(inode, start_blk); > > + phys = __is_valid_data_blkaddr(map.m_pblk) ? > > + blks_to_bytes(inode, map.m_pblk) : 0; > > + size = blks_to_bytes(inode, map.m_len); > > + flags = 0; > > + > > + if (compr_cluster) { > > + flags = FIEMAP_EXTENT_ENCODED; > > + count_in_cluster += map.m_len; > > + if (count_in_cluster == cluster_size) { > > + compr_cluster = false; > > + size += blks_to_bytes(inode, 1); > > + } > > + } else if (map.m_flags & F2FS_MAP_UNWRITTEN) { > > + flags = FIEMAP_EXTENT_UNWRITTEN; > > + } > > - start_blk += bytes_to_blks(inode, size); > > + start_blk += bytes_to_blks(inode, size); > > + } > > prep_next: > > cond_resched(); > >