From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30408C4338F for ; Tue, 27 Jul 2021 13:54:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1048461220 for ; Tue, 27 Jul 2021 13:54:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232341AbhG0Nyl (ORCPT ); Tue, 27 Jul 2021 09:54:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbhG0Nyk (ORCPT ); Tue, 27 Jul 2021 09:54:40 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4C88C061757 for ; Tue, 27 Jul 2021 06:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=94KGTGnoJcX5t7q4D/yqCZ28O/oj4P6pI9cIi1qPWfw=; b=PpF9BlQPRed+CEBDbT7tn4qAcb sqeAfbMWYkZr6oi/FCxfJf8Da5LrxpYQGoYoX45VrHQZl7tClh+sb6iGkawibTAFuNq0tcZyrw8H2 KOesPOTKkhQo4ApWa5ljKAzgPEFgzCBw2VmDctfmf3pZvoSkEk5vcTvuBZn7vI9j0b0b2nf07MMuc iFymfGaKh/TPgiB5i+5FgiDm1+hGhpG2qi6bNMywIwym5ZzGvJBWNYfHiq3Gf+jevRdbfocvlo9vQ 88aA3tqpnjyD+6fwmLredukjlay9ctNh09gl/nVTwHhNqIj1uTeDN9EQcqJ6hSdYpIeWcGXhI+hhu 1ATdccpQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8NXQ-00EzGA-VN; Tue, 27 Jul 2021 13:54:28 +0000 Date: Tue, 27 Jul 2021 06:54:28 -0700 From: Luis Chamberlain To: Bruno Goncalves Cc: Rasmus Villemoes , Alexander Egorenkov , akpm@linux-foundation.org, bp@alien8.de, corbet@lwn.net, gregkh@linuxfoundation.org, jeyu@kernel.org, linux-kernel@vger.kernel.org, ndesaulniers@google.com, torvalds@linux-foundation.org, Dave Young Subject: Re: [PATCH v3 1/2] init/initramfs.c: do unpacking asynchronously Message-ID: References: <87sg04p315.fsf@oc8242746057.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 27, 2021 at 09:31:54AM +0200, Bruno Goncalves wrote: > On Mon, Jul 26, 2021 at 1:46 PM Rasmus Villemoes > wrote: > > > > On 24/07/2021 09.46, Alexander Egorenkov wrote: > > > Hello, > > > > > > since e7cb072eb988 ("init/initramfs.c: do unpacking asynchronously"), we > > > started seeing the following problem on s390 arch regularly: > > > > > > [ 5.039734] wait_for_initramfs() called before rootfs_initcalls So some context here, which might help. The initramfs_cookie is initialized until a a rootfs_initcall() is called, in this case populate_rootfs(). The code is small, so might as well include it: static int __init populate_rootfs(void) { initramfs_cookie = async_schedule_domain(do_populate_rootfs, NULL, &initramfs_domain); if (!initramfs_async) wait_for_initramfs(); return 0; } rootfs_initcall(populate_rootfs); The warning you see comes from a situation where a wait_for_initramfs() gets called but we haven't yet initialized initramfs_cookie. There are only a few calls for wait_for_initramfs() in the kernel, and the only thing I can think of is that somehow s390 may rely on a usermode helper early on, but not every time. What umh calls does s390 issue? > Unfortunately, we haven't been able to find the root cause, but since > June 23rd we haven't hit this panic... > > Btw, this panic we were hitting only when testing kernels from "scsi" > and "block" trees. Do you use drdb maybe? Luis