linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Phillip Potter <phil@philpotter.co.uk>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-staging@lists.linux.dev,
	Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: Re: [PATCH v3 0/7] staging: rtl8188eu: replace driver with better version
Date: Tue, 27 Jul 2021 16:28:33 +0200	[thread overview]
Message-ID: <YQAYER8JxrXG0f+G@kroah.com> (raw)
In-Reply-To: <c42ded8d-8027-eee3-c1c5-54e0736a1758@lwfinger.net>

On Tue, Jul 27, 2021 at 09:13:09AM -0500, Larry Finger wrote:
> On 7/27/21 8:47 AM, Greg KH wrote:
> > On Tue, Jul 27, 2021 at 02:25:34PM +0100, Phillip Potter wrote:
> > > On Tue, 27 Jul 2021 at 14:06, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > > 
> > > > On Sat, Jul 24, 2021 at 01:10:48AM +0100, Phillip Potter wrote:
> > > > > I had to break this patchset up a bit to get around the file size limits
> > > > > on the mailing list, and also I removed the hostapd stuff which is
> > > > > userspace related and therefore not required.
> > > > > 
> > > > > The driver currently in staging is older and less functional than the
> > > > > version on Larry Finger's GitHub account, based upon v4.1.4_6773.20130222.
> > > > > This series of patches therefore:
> > > > > 
> > > > > (1) Removes the current driver from staging.
> > > > > (2) Imports the GitHub version mentioned above in its place.
> > > > 
> > > > Let's do (2) first before worrying about (1), given that we can't get a
> > > > version of (2) that actually builds yet :)
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > 
> > > Dear Greg,
> > > 
> > > I'm confused - v3 patchset builds fine for me after applying in
> > > sequence from 1 to 7?
> > 
> > Why does kbuild report problems?
> > 
> > Anyway, please let's just add the new driver in a new directory, get it
> > building, and then we can remove the old one.  That way patches will
> > continue to work and there's no confusion when backporting patches as
> > the code bases are different.
> 
> I get no kbuild problems in the staging-next branch. I have no idea why the
> test robot is reporting errors.
> 
> Keeping the old rtl8188eu directory and builds will result in 3 drivers
> competing for the hardware including rtl8xxxu, rtl8188eu, and r8188eu.

I will only "keep" it around for a day at most.  I will delete the old
driver, I just do not want the "new" driver in the same directory as the
existing one to make it easier to handle changes over time.

thanks,

greg k-h

  reply	other threads:[~2021-07-27 14:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24  0:10 [PATCH v3 0/7] staging: rtl8188eu: replace driver with better version Phillip Potter
2021-07-24  0:10 ` [PATCH v3 1/7] staging: rtl8188eu: remove existing staging driver Phillip Potter
2021-07-24  0:10 ` [PATCH v3 2/7] staging: r8188eu: introduce new core dir for RTL8188eu driver Phillip Potter
2021-07-24  0:10 ` [PATCH v3 3/7] staging: r8188eu: introduce new hal " Phillip Potter
2021-07-24  0:10 ` [PATCH v3 4/7] staging: r8188eu: introduce new os_dep " Phillip Potter
2021-07-24 19:33   ` kernel test robot
2021-07-24 19:33   ` [RFC PATCH] staging: r8188eu: fix duplicated inclusion kernel test robot
2021-07-24  0:10 ` [PATCH v3 5/7] staging: r8188eu: introduce new include dir for RTL8188eu driver Phillip Potter
2021-07-24  0:10 ` [PATCH v3 6/7] staging: r8188eu: introduce new supporting files " Phillip Potter
2021-07-24  0:10 ` [PATCH v3 7/7] staging: r8188eu: attach newly imported driver to build system Phillip Potter
2021-07-24  5:31   ` kernel test robot
2021-07-25  5:37   ` kernel test robot
2021-07-27 13:06 ` [PATCH v3 0/7] staging: rtl8188eu: replace driver with better version Greg KH
2021-07-27 13:25   ` Phillip Potter
2021-07-27 13:47     ` Greg KH
2021-07-27 14:13       ` Larry Finger
2021-07-27 14:28         ` Greg KH [this message]
2021-07-27 14:34           ` Phillip Potter
2021-07-27 15:46             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQAYER8JxrXG0f+G@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).