linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Wan Jiabing <wanjiabing@vivo.com>,
	Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] scripts: make some scripts executable
Date: Tue, 27 Jul 2021 17:56:38 +0200	[thread overview]
Message-ID: <YQAsth0TA3AwtxvK@kroah.com> (raw)
In-Reply-To: <20210727153924.79473-1-masahiroy@kernel.org>

On Wed, Jul 28, 2021 at 12:39:24AM +0900, Masahiro Yamada wrote:
> Set the x bit to some scripts to make them directly executable.
> 
> Especially, scripts/checkdeclares.pl is not hooked by anyone.
> It should be executable since it is tedious to type
> 'perl scripts/checkdeclares.pl'.
> 
> The original patch [1] set the x bit properly, but it was lost when
> it was merged as commit 21917bded72c ("scripts: a new script for
> checking duplicate struct declaration").
> 
> [1] https://lore.kernel.org/lkml/20210401110943.1010796-1-wanjiabing@vivo.com/
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  scripts/checkdeclares.pl               | 0
>  scripts/gcc-plugins/gen-random-seed.sh | 0
>  scripts/syscallnr.sh                   | 0
>  scripts/xen-hypercalls.sh              | 0
>  4 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 scripts/checkdeclares.pl
>  mode change 100644 => 100755 scripts/gcc-plugins/gen-random-seed.sh
>  mode change 100644 => 100755 scripts/syscallnr.sh
>  mode change 100644 => 100755 scripts/xen-hypercalls.sh

Please no, as other tools (i.e. patch), can not set mode bits, and some
people still rely on patch in places.

If these need to be called by other parts of the build, we should
execute them properly, not rely on the mode settings.

thanks,

greg k-h

  reply	other threads:[~2021-07-27 15:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 15:39 [PATCH] scripts: make some scripts executable Masahiro Yamada
2021-07-27 15:56 ` Greg KH [this message]
2021-07-28  1:03   ` Masahiro Yamada
2021-07-28  1:22     ` Randy Dunlap
2021-07-28  6:27     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQAsth0TA3AwtxvK@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).