From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3934AC4338F for ; Wed, 28 Jul 2021 00:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15EAA60F9D for ; Wed, 28 Jul 2021 00:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233605AbhG1ASu (ORCPT ); Tue, 27 Jul 2021 20:18:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232778AbhG1ASs (ORCPT ); Tue, 27 Jul 2021 20:18:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AE1E860F6B; Wed, 28 Jul 2021 00:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627431528; bh=u9teLUiNfbExZwY0su7A/WppbGW4OwOm30JjrzJwpT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OiLLOwBj4S6iTjmD6cWVEkPVs1ROFYXiX4ey6t1HSTViAqEkrOHQyzFepfkVCpmmW 1WBfLqH7TwtJzd4Bk4QLQ4i5Z2DQYw62cTkPg6TW/rqCByaLqVUS027YxlbO7WQ7FZ /he1w2ODl8Gp09NgEL1SHFqv6JhRjh13dpwFElcJCHcd4bJ8/dirT0BUZKmMxAx72+ 2uNTjdttSI0N08sbRiDttRdHJaXwe/6c6eHNWBoTIjJFETOyUi1d2VddxL49XOMbE4 7gvj8S4PQ78vzjbV0vKzkpzg+ZZ/WYI6B8WUf3XnYMkXU8uKwBfTNwdNYwAdjJm6gT eXBH6ZFlHettQ== Date: Tue, 27 Jul 2021 17:18:45 -0700 From: Nathan Chancellor To: Brian Cain , Andrew Morton Cc: Nick Desaulniers , linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] Hexagon: Export raw I/O routines for modules Message-ID: References: <20210708233849.3140194-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210708233849.3140194-1-nathan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 08, 2021 at 04:38:50PM -0700, Nathan Chancellor wrote: > When building ARCH=hexagon allmodconfig, the following errors occur: > > ERROR: modpost: "__raw_readsl" [drivers/i3c/master/svc-i3c-master.ko] undefined! > ERROR: modpost: "__raw_writesl" [drivers/i3c/master/dw-i3c-master.ko] undefined! > ERROR: modpost: "__raw_readsl" [drivers/i3c/master/dw-i3c-master.ko] undefined! > ERROR: modpost: "__raw_writesl" [drivers/i3c/master/i3c-master-cdns.ko] undefined! > ERROR: modpost: "__raw_readsl" [drivers/i3c/master/i3c-master-cdns.ko] undefined! > > Export these symbols so that modules can use them without any errors. > > Fixes: 013bf24c3829 ("Hexagon: Provide basic implementation and/or stubs for I/O routines.") > Signed-off-by: Nathan Chancellor > --- > > It would be nice if this could get into 5.14 at some point so that we > can build ARCH=hexagon allmodconfig in our CI. > > arch/hexagon/lib/io.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/hexagon/lib/io.c b/arch/hexagon/lib/io.c > index d35d69d6588c..55f75392857b 100644 > --- a/arch/hexagon/lib/io.c > +++ b/arch/hexagon/lib/io.c > @@ -27,6 +27,7 @@ void __raw_readsw(const void __iomem *addr, void *data, int len) > *dst++ = *src; > > } > +EXPORT_SYMBOL(__raw_readsw); > > /* > * __raw_writesw - read words a short at a time > @@ -47,6 +48,7 @@ void __raw_writesw(void __iomem *addr, const void *data, int len) > > > } > +EXPORT_SYMBOL(__raw_writesw); > > /* Pretty sure len is pre-adjusted for the length of the access already */ > void __raw_readsl(const void __iomem *addr, void *data, int len) > @@ -62,6 +64,7 @@ void __raw_readsl(const void __iomem *addr, void *data, int len) > > > } > +EXPORT_SYMBOL(__raw_readsl); > > void __raw_writesl(void __iomem *addr, const void *data, int len) > { > @@ -76,3 +79,4 @@ void __raw_writesl(void __iomem *addr, const void *data, int len) > > > } > +EXPORT_SYMBOL(__raw_writesl); > > base-commit: f55966571d5eb2876a11e48e798b4592fa1ffbb7 > -- > 2.32.0.93.g670b81a890 Ping? Brian, if you do not want to carry this, can you give an ack so that Andrew can? Cheers, Nathan