From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Stephen Boyd <sboyd@kernel.org>, Taniya Das <tdas@codeaurora.org>, Michael Turquette <mturquette@baylibre.com>, Andy Gross <agross@kernel.org>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 2/5] PM: clk: add devm_pm_clk_create helper Date: Wed, 28 Jul 2021 13:05:59 -0700 [thread overview] Message-ID: <YQG4pz/z2nBNA+tJ@ripper> (raw) In-Reply-To: <20210728142445.774158-3-dmitry.baryshkov@linaro.org> On Wed 28 Jul 07:24 PDT 2021, Dmitry Baryshkov wrote: > Add devm_pm_clk_create helper, devres-enabled version of the > pm_clk_create(), which will call pm_clk_destroy at the correct time. > As with path 1, please describe why this is a good thing. (I definitely think it is, but I've been part of the discussion leading up to this patch) > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/base/power/clock_ops.c | 17 +++++++++++++++++ > include/linux/pm_clock.h | 5 +++++ > 2 files changed, 22 insertions(+) > > diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c > index 0251f3e6e61d..4110c19c08dc 100644 > --- a/drivers/base/power/clock_ops.c > +++ b/drivers/base/power/clock_ops.c > @@ -519,6 +519,23 @@ void pm_clk_destroy(struct device *dev) > } > EXPORT_SYMBOL_GPL(pm_clk_destroy); > > +static void pm_clk_destroy_action(void *data) > +{ > + pm_clk_destroy(data); > +} > + As this is an addition to the API, it deserves some kerneldoc. Regards, Bjorn > +int devm_pm_clk_create(struct device *dev) > +{ > + int ret; > + > + ret = pm_clk_create(dev); > + if (ret) > + return ret; > + > + return devm_add_action_or_reset(dev, pm_clk_destroy_action, dev); > +} > +EXPORT_SYMBOL_GPL(devm_pm_clk_create); > + > /** > * pm_clk_suspend - Disable clocks in a device's PM clock list. > * @dev: Device to disable the clocks for. > diff --git a/include/linux/pm_clock.h b/include/linux/pm_clock.h > index 8ddc7860e131..ada3a0ab10bf 100644 > --- a/include/linux/pm_clock.h > +++ b/include/linux/pm_clock.h > @@ -47,6 +47,7 @@ extern void pm_clk_remove(struct device *dev, const char *con_id); > extern void pm_clk_remove_clk(struct device *dev, struct clk *clk); > extern int pm_clk_suspend(struct device *dev); > extern int pm_clk_resume(struct device *dev); > +extern int devm_pm_clk_create(struct device *dev); > #else > static inline bool pm_clk_no_clocks(struct device *dev) > { > @@ -83,6 +84,10 @@ static inline void pm_clk_remove(struct device *dev, const char *con_id) > static inline void pm_clk_remove_clk(struct device *dev, struct clk *clk) > { > } > +static inline int devm_pm_clk_create(struct device *dev) > +{ > + return -EINVAL; > +} > #endif > > #ifdef CONFIG_HAVE_CLK > -- > 2.30.2 >
next prev parent reply other threads:[~2021-07-28 20:07 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-28 14:24 [PATCH v2 0/5] PM: add two devres helpers and use them in qcom cc Dmitry Baryshkov 2021-07-28 14:24 ` [PATCH v2 1/5] PM: runtime: add devm_pm_runtime_enable helper Dmitry Baryshkov 2021-07-28 20:04 ` Bjorn Andersson 2021-07-28 14:24 ` [PATCH v2 2/5] PM: clk: add devm_pm_clk_create helper Dmitry Baryshkov 2021-07-28 20:05 ` Bjorn Andersson [this message] 2021-07-28 14:24 ` [PATCH v2 3/5] clk: qcom: use devm_pm_runtime_enable and devm_pm_clk_create Dmitry Baryshkov 2021-07-28 15:00 ` Bjorn Andersson 2021-07-29 14:28 ` Dmitry Baryshkov 2021-07-28 14:24 ` [PATCH v2 4/5] clk: qcom: use common code for qcom_cc_probe_by_index Dmitry Baryshkov 2021-07-28 14:24 ` [PATCH v2 5/5] clk: qcom: move pm_clk functionality into common code Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YQG4pz/z2nBNA+tJ@ripper \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=pavel@ucw.cz \ --cc=rjw@rjwysocki.net \ --cc=sboyd@kernel.org \ --cc=tdas@codeaurora.org \ --subject='Re: [PATCH v2 2/5] PM: clk: add devm_pm_clk_create helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).