From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E9FC4338F for ; Wed, 28 Jul 2021 20:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D59F460F5E for ; Wed, 28 Jul 2021 20:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231378AbhG1UHy (ORCPT ); Wed, 28 Jul 2021 16:07:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbhG1UHx (ORCPT ); Wed, 28 Jul 2021 16:07:53 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C9FEC061757 for ; Wed, 28 Jul 2021 13:07:50 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id y18so5266562oiv.3 for ; Wed, 28 Jul 2021 13:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=97hQfQK7XavPSltv9pN4yF2y5jNc7cIdloHZZGHQCvY=; b=Z7jTTKBFGpWIxboKqwgJRsOZp1J+aWDmjni8p5+XEVDRVJmY29+ni5XltyAcjXJrPd VKRiyGY2cxhdfvhTRdTJXxMi8S4rhnmsf7fgxGaIh3UvIFWi4IDtUyJAop5wHOt23ZWF 4DS/rBN4kxsmc5k3UIkqOFWLnzdGHlERYnLb/rN8QlBNhMpET6iELjrDWctsQitUPXGL 2sckHJR93BoAb3Tm7MNt5hGZ34d1TvqTBveiQqtTZfbncswKMzJrgB6ult5Anul6wbBt IngUJZkLp/kFIdNqQ4EVmz2DH5drGaBqdJBFNlZL/yfplvskUs3XOZoFU1YNCvGzVSnO EDgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=97hQfQK7XavPSltv9pN4yF2y5jNc7cIdloHZZGHQCvY=; b=OTdChzWI7nlQxv3zv14yE9BAl1UQ5buLhgSnVinB5SW0lL9snrAdZtbpBWAQUOVA6U tz8SOblRR/LAdYyfU7eCC9EhNpzdwh0CaJefQacU4oN5C8jCn7IjZH2yCCqKgQYxK1TH PHBakI2xGzeErsCshMOqIcanM3X2AKJkLs1mP90W34sBrVmNY5q0CtLteqelGKbmeKug huHoSlc6VCSDXmoxSnJm8RW85mY3bFqbQE3lEFpWAzUSo1WQle0qDWEpMqiXayJoFyr/ Ys4Io2wetHeCGeJRxQCfA1mRaqyjmp47CrLNjcYLpR4Np51k2STX7V/aqF+Gufew0SEI Wi1A== X-Gm-Message-State: AOAM531BBUWe2iepOQ+Ak9kZ6lSMQ9UbfhGVXwSKkNh2q0AGvXkse//v bZLS4pjkIh58sXe2+dTMgeGGgA== X-Google-Smtp-Source: ABdhPJwD7U8+qAvbZ4kuKnlj7p/+LPIrjaNSnetymU4fcJ2ltcIGDeO08kf0oVPEIdx8JqShaVs4sA== X-Received: by 2002:aca:1e12:: with SMTP id m18mr7648287oic.95.1627502869900; Wed, 28 Jul 2021 13:07:49 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n1sm182047otk.34.2021.07.28.13.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 13:07:49 -0700 (PDT) Date: Wed, 28 Jul 2021 13:05:59 -0700 From: Bjorn Andersson To: Dmitry Baryshkov Cc: "Rafael J. Wysocki" , Pavel Machek , Greg Kroah-Hartman , Stephen Boyd , Taniya Das , Michael Turquette , Andy Gross , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 2/5] PM: clk: add devm_pm_clk_create helper Message-ID: References: <20210728142445.774158-1-dmitry.baryshkov@linaro.org> <20210728142445.774158-3-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728142445.774158-3-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 28 Jul 07:24 PDT 2021, Dmitry Baryshkov wrote: > Add devm_pm_clk_create helper, devres-enabled version of the > pm_clk_create(), which will call pm_clk_destroy at the correct time. > As with path 1, please describe why this is a good thing. (I definitely think it is, but I've been part of the discussion leading up to this patch) > Signed-off-by: Dmitry Baryshkov > --- > drivers/base/power/clock_ops.c | 17 +++++++++++++++++ > include/linux/pm_clock.h | 5 +++++ > 2 files changed, 22 insertions(+) > > diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c > index 0251f3e6e61d..4110c19c08dc 100644 > --- a/drivers/base/power/clock_ops.c > +++ b/drivers/base/power/clock_ops.c > @@ -519,6 +519,23 @@ void pm_clk_destroy(struct device *dev) > } > EXPORT_SYMBOL_GPL(pm_clk_destroy); > > +static void pm_clk_destroy_action(void *data) > +{ > + pm_clk_destroy(data); > +} > + As this is an addition to the API, it deserves some kerneldoc. Regards, Bjorn > +int devm_pm_clk_create(struct device *dev) > +{ > + int ret; > + > + ret = pm_clk_create(dev); > + if (ret) > + return ret; > + > + return devm_add_action_or_reset(dev, pm_clk_destroy_action, dev); > +} > +EXPORT_SYMBOL_GPL(devm_pm_clk_create); > + > /** > * pm_clk_suspend - Disable clocks in a device's PM clock list. > * @dev: Device to disable the clocks for. > diff --git a/include/linux/pm_clock.h b/include/linux/pm_clock.h > index 8ddc7860e131..ada3a0ab10bf 100644 > --- a/include/linux/pm_clock.h > +++ b/include/linux/pm_clock.h > @@ -47,6 +47,7 @@ extern void pm_clk_remove(struct device *dev, const char *con_id); > extern void pm_clk_remove_clk(struct device *dev, struct clk *clk); > extern int pm_clk_suspend(struct device *dev); > extern int pm_clk_resume(struct device *dev); > +extern int devm_pm_clk_create(struct device *dev); > #else > static inline bool pm_clk_no_clocks(struct device *dev) > { > @@ -83,6 +84,10 @@ static inline void pm_clk_remove(struct device *dev, const char *con_id) > static inline void pm_clk_remove_clk(struct device *dev, struct clk *clk) > { > } > +static inline int devm_pm_clk_create(struct device *dev) > +{ > + return -EINVAL; > +} > #endif > > #ifdef CONFIG_HAVE_CLK > -- > 2.30.2 >