linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] s390: move the install rule to arch/s390/Makefile
@ 2021-07-29 14:23 Masahiro Yamada
  2021-07-29 18:50 ` Heiko Carstens
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2021-07-29 14:23 UTC (permalink / raw)
  To: Heiko Carstens, Vasily Gorbik, Christian Borntraeger, linux-s390
  Cc: Masahiro Yamada, Alexander Egorenkov, linux-kernel

Currently, the install target in arch/s390/Makefile descends into
arch/s390/boot/Makefile to invoke the shell script, but there is no
good reason to do so.

arch/s390/Makefile can run the shell script directly.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/s390/Makefile      | 3 ++-
 arch/s390/boot/Makefile | 4 ----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/s390/Makefile b/arch/s390/Makefile
index 1e3172877982..17dc4f1ac4fa 100644
--- a/arch/s390/Makefile
+++ b/arch/s390/Makefile
@@ -142,7 +142,8 @@ all: bzImage
 KBUILD_IMAGE	:= $(boot)/bzImage
 
 install:
-	$(Q)$(MAKE) $(build)=$(boot) $@
+	sh -x $(srctree)/$(boot)/install.sh $(KERNELRELEASE) $(KBUILD_IMAGE) \
+	      System.map "$(INSTALL_PATH)"
 
 bzImage: vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
diff --git a/arch/s390/boot/Makefile b/arch/s390/boot/Makefile
index 41a64b8dce25..6e4b56470b85 100644
--- a/arch/s390/boot/Makefile
+++ b/arch/s390/boot/Makefile
@@ -69,7 +69,3 @@ $(obj)/compressed/vmlinux: $(obj)/startup.a FORCE
 
 $(obj)/startup.a: $(OBJECTS) FORCE
 	$(call if_changed,ar)
-
-install:
-	sh -x  $(srctree)/$(obj)/install.sh $(KERNELRELEASE) $(obj)/bzImage \
-	      System.map "$(INSTALL_PATH)"
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] s390: move the install rule to arch/s390/Makefile
  2021-07-29 14:23 [PATCH] s390: move the install rule to arch/s390/Makefile Masahiro Yamada
@ 2021-07-29 18:50 ` Heiko Carstens
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2021-07-29 18:50 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Vasily Gorbik, Christian Borntraeger, linux-s390,
	Alexander Egorenkov, linux-kernel

On Thu, Jul 29, 2021 at 11:23:38PM +0900, Masahiro Yamada wrote:
> Currently, the install target in arch/s390/Makefile descends into
> arch/s390/boot/Makefile to invoke the shell script, but there is no
> good reason to do so.
> 
> arch/s390/Makefile can run the shell script directly.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  arch/s390/Makefile      | 3 ++-
>  arch/s390/boot/Makefile | 4 ----
>  2 files changed, 2 insertions(+), 5 deletions(-)

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-29 18:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 14:23 [PATCH] s390: move the install rule to arch/s390/Makefile Masahiro Yamada
2021-07-29 18:50 ` Heiko Carstens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).