linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: kenchappa.demakkanavar@intel.com
Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	dinguyen@kernel.org, furong.zhou@intel.com,
	kris.pan@linux.intel.com, kris.pan@intel.com,
	mgross@linux.intel.com, mark.gross@intel.com
Subject: Re: [PATCH V2 2/3] dt-bindings: arm: Add Thunder Bay bindings
Date: Thu, 29 Jul 2021 13:40:55 -0600	[thread overview]
Message-ID: <YQMER155dEYk3ets@robh.at.kernel.org> (raw)
In-Reply-To: <1626758569-27176-3-git-send-email-kenchappa.demakkanavar@intel.com>

On Tue, Jul 20, 2021 at 10:52:48AM +0530, kenchappa.demakkanavar@intel.com wrote:
> From: "Pan, Kris" <kris.pan@intel.com>

Kris Pan <kris.pan@intel.com>

> 
> Document Intel Movidius SoC code-named Thunder Bay, along with the
> Thunder Bay Full and Prime configuration board.
> 
> Add maintainers for the new Intel Movidius SoC code-named Thunder Bay.
> 
> Signed-off-by: Pan, Kris <kris.pan@intel.com>
> Signed-off-by: Demakkanavar, Kenchappa <kenchappa.demakkanavar@intel.com>

"First name last name" here too.

> ---
>  .../devicetree/bindings/arm/intel,thunderbay.yaml   | 21 +++++++++++++++++++++
>  MAINTAINERS                                         |  5 +++++
>  2 files changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/intel,thunderbay.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/intel,thunderbay.yaml b/Documentation/devicetree/bindings/arm/intel,thunderbay.yaml
> new file mode 100644
> index 0000000..2b9d5f6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/intel,thunderbay.yaml
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/intel,thunderbay.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Thunder Bay platform device tree bindings
> +
> +maintainers:
> +  - Demakkanavar, Kenchappa <kenchappa.demakkanavar@intel.com>

ditto

> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - intel,thunderbay
> +      - const: intel,thunderbay

Not valid to have duplicate strings.

Like everyone else, you need $nodename schema here to define this is 
for the root node.

> +
> +additionalProperties: true
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 503fd21..041f9a0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1992,6 +1992,11 @@ S:	Maintained
>  F:	arch/arm/mach-pxa/stargate2.c
>  F:	drivers/pcmcia/pxa2xx_stargate2.c
>  
> +ARM/INTEL THUNDERBAY ARCHITECTURE
> +M:	Demakkanavar, Kenchappa <kenchappa.demakkanavar@intel.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/arm/intel,thunderbay.yaml
> +
>  ARM/INTEL XSC3 (MANZANO) ARM CORE
>  M:	Lennert Buytenhek <kernel@wantstofly.org>
>  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> -- 
> 2.7.4
> 
> 

  reply	other threads:[~2021-07-29 19:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20  5:22 [PATCH V2 0/3] Add initial Thunder Bay SoC / Board support kenchappa.demakkanavar
2021-07-20  5:22 ` [PATCH V2 1/3] arm64: Add config for Thunder Bay SoC kenchappa.demakkanavar
2021-07-20  5:22 ` [PATCH V2 2/3] dt-bindings: arm: Add Thunder Bay bindings kenchappa.demakkanavar
2021-07-29 19:40   ` Rob Herring [this message]
2021-07-20  5:22 ` [PATCH V2 3/3] arm64: dts: add initial device tree for Thunder Bay SoC kenchappa.demakkanavar
2021-07-29 19:53   ` Rob Herring
2021-08-27  7:55     ` Demakkanavar, Kenchappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQMER155dEYk3ets@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=furong.zhou@intel.com \
    --cc=kenchappa.demakkanavar@intel.com \
    --cc=kris.pan@intel.com \
    --cc=kris.pan@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.gross@intel.com \
    --cc=mgross@linux.intel.com \
    --cc=will@kernel.org \
    --subject='Re: [PATCH V2 2/3] dt-bindings: arm: Add Thunder Bay bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).