From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB678C4338F for ; Thu, 29 Jul 2021 22:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFCB86044F for ; Thu, 29 Jul 2021 22:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234601AbhG2WvX (ORCPT ); Thu, 29 Jul 2021 18:51:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:32966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233516AbhG2WvW (ORCPT ); Thu, 29 Jul 2021 18:51:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 450736023E; Thu, 29 Jul 2021 22:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627599078; bh=CcoVvdaUEJ4hNSxZtFmgxQoFCn0/MeIH+Fu9CTIgsNU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IKHxuMjyM2ZpOaccpg6ZB98aZBJp1UM6Nfbjpj1eRXzWblrrUFZvyloRMtE4XGn2N cnU8jIcI1R9y43wuVi4i8UoCZTu8U6R65oAymG/ENh+sySgB3oyj+IFg7URi9kqphD nUoBqwQzw5vTcivqTq6/QovmmAO962Tv7aszRxJ4uRV8+MSHXJHaP9SV4qOYrezHno Gyqr3UbrYAi0wb5F5f/bMByQfKmusPCrNGoy4i+LK8H9Po+SbYFX5oNy6sutJ5CFKh 8rarVuzoc6HXiOGjZCAepMLVc3icq1bpDzaTodKzXbZhbltvfPxAPeNinaYB03aJXf OACP3vUkDmfAA== Date: Thu, 29 Jul 2021 15:51:16 -0700 From: Jaegeuk Kim To: Chao Yu Cc: Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com, Daeho Jeong , Eric Biggers Subject: Re: [f2fs-dev] [PATCH v4] f2fs: change fiemap way in printing compression chunk Message-ID: References: <20210726041819.2059593-1-daeho43@gmail.com> <8c0d05d2-3988-a8a4-5403-1173f25b822b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c0d05d2-3988-a8a4-5403-1173f25b822b@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/29, Chao Yu wrote: > On 2021/7/28 1:17, Jaegeuk Kim wrote: > > Do we really need to catch this in fiemap? What about giving the current > > Yes, I think so. > > > layout with warning message and setting NEED_FSCK? > > Sure, > > How about doing sanity check on cluster metadata whenever it is going to > be accessed, like we did for single blkaddr with f2fs_is_valid_blkaddr()? I think that'd be viable. > > Thanks,