archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <>
To: "Rafael J. Wysocki" <>
Cc: Linux PCI <>,
	Linux ACPI <>,
	Linux PM <>,
	LKML <>,
	Bjorn Helgaas <>,
	Kai-Heng Feng <>,
	Utkarsh H Patel <>,
	Koba Ko <>
Subject: Re: [PATCH v1 2/2] PCI: PM: Enable PME if it can be signaled from D3cold
Date: Fri, 30 Jul 2021 13:28:10 +0300	[thread overview]
Message-ID: <YQPUOgxldaqpxOxL@lahna> (raw)
In-Reply-To: <1791325.tdWV9SEqCh@kreacher>

On Thu, Jul 29, 2021 at 04:49:10PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <>
> PME signaling is only enabled by __pci_enable_wake() if the target
> device can signal PME from the given target power state (to avoid
> pointless reconfiguration of the device), but if the hierarchy above
> the device goes into D3cold, the device itself will end up in D3cold
> too, so if it can signal PME from D3cold, it should be enabled to
> do so in __pci_enable_wake().
> [Note that if the device does not end up in D3cold and it cannot
>  signal PME from the original target power state, it will not signal
>  PME, so in that case the behavior does not change.]
> Link:
> Fixes: 5bcc2fb4e815 ("PCI PM: Simplify PCI wake-up code")
> Reported-by: Mika Westerberg <>

Reviewed-by: Mika Westerberg <>

Also this solves the reported issue so,

Tested-by: Mika Westerberg <>


  reply	other threads:[~2021-07-30 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 14:46 [PATCH v1 0/2] PCI: PM: Fix handling of device that can only signal PME from D3cold Rafael J. Wysocki
2021-07-29 14:48 ` [PATCH v1 1/2] PCI: PM: Add special case handling for PCIe device wakeup Rafael J. Wysocki
2021-07-29 15:09   ` Rafael J. Wysocki
2021-07-29 15:54   ` [PATCH v1.1 1/2] PCI: PM: Avoid forcing PCI_D0 for wakeup reasons inconsistently Rafael J. Wysocki
2021-07-30 10:26     ` Mika Westerberg
2021-07-29 14:49 ` [PATCH v1 2/2] PCI: PM: Enable PME if it can be signaled from D3cold Rafael J. Wysocki
2021-07-30 10:28   ` Mika Westerberg [this message]
2021-07-30 12:13     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQPUOgxldaqpxOxL@lahna \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).