linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] lockdep/selftests: Fix duplicate included locking-selftest-softirq.h
@ 2021-07-30 10:24 Jiapeng Chong
  2021-07-30 10:36 ` Boqun Feng
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-07-30 10:24 UTC (permalink / raw)
  To: peterz; +Cc: mingo, will, longman, boqun.feng, linux-kernel, Jiapeng Chong

Clean up the following includecheck warning:

./lib/locking-selftest.c: locking-selftest-softirq.h is included more
than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: cae2ed9aa573 ("[PATCH] lockdep: locking API self tests")
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 lib/locking-selftest.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
index 161108e..6010445 100644
--- a/lib/locking-selftest.c
+++ b/lib/locking-selftest.c
@@ -1252,7 +1252,6 @@ static void rwsem_ABBA3(void)
 #include "locking-selftest-wlock.h"
 GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion2_hard_wlock)
 
-#include "locking-selftest-softirq.h"
 #include "locking-selftest-rlock.h"
 GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion2_soft_rlock)
 
@@ -1306,7 +1305,6 @@ static void rwsem_ABBA3(void)
 #include "locking-selftest-wlock.h"
 GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion3_hard_wlock)
 
-#include "locking-selftest-softirq.h"
 #include "locking-selftest-rlock.h"
 GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion3_soft_rlock)
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] lockdep/selftests: Fix duplicate included locking-selftest-softirq.h
  2021-07-30 10:24 [PATCH] lockdep/selftests: Fix duplicate included locking-selftest-softirq.h Jiapeng Chong
@ 2021-07-30 10:36 ` Boqun Feng
  0 siblings, 0 replies; 2+ messages in thread
From: Boqun Feng @ 2021-07-30 10:36 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: peterz, mingo, will, longman, linux-kernel

Hi,

On Fri, Jul 30, 2021 at 06:24:42PM +0800, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
> 
> ./lib/locking-selftest.c: locking-selftest-softirq.h is included more
> than once.
> 

Those inclusions in the file are used as poor man's template, IOW, the
header files redefine some names so that we can use one template to
generate many similar functions.

So no need to fix, thanks! But if you have a better idea to generate
functions, please let me know ;-)

Regards,
Boqun

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: cae2ed9aa573 ("[PATCH] lockdep: locking API self tests")
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  lib/locking-selftest.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
> index 161108e..6010445 100644
> --- a/lib/locking-selftest.c
> +++ b/lib/locking-selftest.c
> @@ -1252,7 +1252,6 @@ static void rwsem_ABBA3(void)
>  #include "locking-selftest-wlock.h"
>  GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion2_hard_wlock)
>  
> -#include "locking-selftest-softirq.h"
>  #include "locking-selftest-rlock.h"
>  GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion2_soft_rlock)
>  
> @@ -1306,7 +1305,6 @@ static void rwsem_ABBA3(void)
>  #include "locking-selftest-wlock.h"
>  GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion3_hard_wlock)
>  
> -#include "locking-selftest-softirq.h"
>  #include "locking-selftest-rlock.h"
>  GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion3_soft_rlock)
>  
> -- 
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-30 10:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 10:24 [PATCH] lockdep/selftests: Fix duplicate included locking-selftest-softirq.h Jiapeng Chong
2021-07-30 10:36 ` Boqun Feng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).