From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CBBC4320A for ; Sat, 31 Jul 2021 02:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CA8C60BD3 for ; Sat, 31 Jul 2021 02:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236544AbhGaC33 (ORCPT ); Fri, 30 Jul 2021 22:29:29 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54846 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhGaC31 (ORCPT ); Fri, 30 Jul 2021 22:29:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=fTMpPnF7MNPIeWiCWwW2KmQn0PAalSgBt+h2ZsLcBHU=; b=l/Uryn7pXFoajvjHHL7k0N/Krr 4ZZhnM75MOm+LJCvJh+wASnN667p+KNfS7Vq+5Q8rwjN06d9RhSlnl9DVOiAEcWeS4yulFwlBpvrP UCwBceM7Jt1KzmZchFuSKSOO+PyYsCIBNuAvzUeHXrvP5fbsVzEhsn/cwbbntAoKrOYk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m9ekJ-00FYZR-Ab; Sat, 31 Jul 2021 04:29:03 +0200 Date: Sat, 31 Jul 2021 04:29:03 +0200 From: Andrew Lunn To: Daniel Walker Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Russell King , Balamurugan Selvarajan , xe-linux-external@cisco.com, "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC-PATCH] net: stmmac: Add KR port support. Message-ID: References: <20210729234443.1713722-1-danielwa@cisco.com> <20210730144830.GO1633923@zorba> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210730144830.GO1633923@zorba> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 30, 2021 at 07:48:30AM -0700, Daniel Walker wrote: > On Fri, Jul 30, 2021 at 05:01:44AM +0200, Andrew Lunn wrote: > > On Thu, Jul 29, 2021 at 04:44:42PM -0700, Daniel Walker wrote: > > > From: Balamurugan Selvarajan > > > > > > For KR port the mii interface is a chip-to-chip > > > interface without a mechanical connector. So PHY > > > inits are not applicable. In this case MAC is > > > configured to operate at forced speed(1000Mbps) > > > and full duplex. Modified driver to accommodate > > > PHY and NON-PHY mode. > > > > I agree with Florian here. Look at all the in kernel examples of a SoC > > MAC connected to an Ethernet switch. Some use rgmii, others 1000BaseX > > or higher. But they all follow the same scheme, and don't need > > invasive MAC driver changes. > > > Can you provide the examples which you looked at ? There are plenty of examples using Freescale FEC and Marvell Ethernet switches: arch/arm/boot/dts/vf610-zii-dev-rev-b.dts Or the Mavell based arch/arm/boot/dts/armada-xp-linksys-mamba.dts Andrew