linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jordy Zomer <jordy@pwning.systems>
Cc: linux-kernel@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net,
	Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH] firewire: ohci: make reg_(read|write) unsigned
Date: Sun, 1 Aug 2021 08:25:23 +0200	[thread overview]
Message-ID: <YQY+U9i8Zw7OAKOO@kroah.com> (raw)
In-Reply-To: <YQY+BL4nR9Loddum@kroah.com>

On Sun, Aug 01, 2021 at 08:24:04AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Jul 31, 2021 at 12:41:12PM +0200, Jordy Zomer wrote:
> > The reg_(read|write) functions used to
> > take a signed integer as an offset parameter.
> > The callers of this function only pass an unsigned integer to it.
> > Therefore to make it obviously safe, let's just make this an unsgined
> > integer as this is used in pointer arithmetics.
> > 
> > Signed-off-by: Jordy Zomer <jordy@pwning.systems>
> > ---
> >  drivers/firewire/ohci.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Same thing should probably also be done in
> drivers/firewire/init_ohci1394_dma.c for the same inline functions,
> right?

And sound/firewire/isight.c also could use this.  Seems like there was
some copy/paste in firewire drivers :)

thanks,

greg k-h

  reply	other threads:[~2021-08-01  6:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 10:41 [PATCH] firewire: ohci: make reg_(read|write) unsigned Jordy Zomer
2021-08-01  6:24 ` Greg Kroah-Hartman
2021-08-01  6:25   ` Greg Kroah-Hartman [this message]
2021-08-01 13:30     ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQY+U9i8Zw7OAKOO@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jordy@pwning.systems \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).