From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82EF9C4338F for ; Mon, 2 Aug 2021 16:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66F5A6100A for ; Mon, 2 Aug 2021 16:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232642AbhHBQUl (ORCPT ); Mon, 2 Aug 2021 12:20:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbhHBQUj (ORCPT ); Mon, 2 Aug 2021 12:20:39 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45AD0C06175F for ; Mon, 2 Aug 2021 09:20:29 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id dw2-20020a17090b0942b0290177cb475142so6582215pjb.2 for ; Mon, 02 Aug 2021 09:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LKSDgoQrvGYLPlpAHnL1xCY18fI5StbO5wi+iDVl4jk=; b=vpvHeto3hln3guSCP5pAX4Ek1PDazugmwcY2YyzwDWs8Ifg3godsndxFaddLeJt3JJ sGbDjODTtZ39kFCAc++1K57NXsamMKXs0iyxzlPtVePMvpZLp4SWWYOeT6pckX/TSfoH 0+zqLqBfP7DiMkJZPFUFqanc2fVMD8VPskHaqlPOnHPYIL9K2xnQ4AYehOvsicPB6EYY FwJPLNScSqzjPLOk1HNboRdXcgnua17PnHWPvEGQVp57LGmm0W0xqhd35lZG0aZd5TzI 0AioNre27K5BSD1RvQNZHflszSUCO8ijNsz/wABMr79cL3ssGnKokCMjwxcCKiGP6yhc CSQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LKSDgoQrvGYLPlpAHnL1xCY18fI5StbO5wi+iDVl4jk=; b=kbSyfF1do2mHE8+rtbXUs+5kENOBTfOyZucnYKwJGgOk+aN2TSFC4cAaGCpf4ueAjX RvPF6gdynovMQgA04PM8Lf+Mwe+mNjwkk/G/scVxto6M/hawcqtXcU06QTJ/LT4O/RQe voFw6nlDcwta/akwllDSnuXJ7D9Ba+IdrdYPrB/XzZNrCHq19gPMlUv03VQRPZrbfQUQ s2yp/NoQJmWAhbbMGwok99y4czTDenOsPSpazqo5n3qO+gTsPDrsOEdEYe2//2eVSV4j F1BLswF23/A6U2Rin3KMrjQ1No3klhFCUNpRjP0UuU6qxdry+OnYhNIdGLdyHqEd28Vi oAAg== X-Gm-Message-State: AOAM5312pgQ3QQ+l23awzuy/FvLL/bYqd1P7INcYGQ72K2U1yjptJD+t H1BfGv1AvbyrMRMWBK8e6V6j7g== X-Google-Smtp-Source: ABdhPJwqBJ35AO52xu3hDxWSn2ir42jHB4/01j2TLEZ3gmIULEQlODgSzdOhe3FPjYkUE7WZCtw+Sg== X-Received: by 2002:a05:6a00:b85:b029:332:1865:fea9 with SMTP id g5-20020a056a000b85b02903321865fea9mr17473384pfj.45.1627921228700; Mon, 02 Aug 2021 09:20:28 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id k3sm12751155pfc.16.2021.08.02.09.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 09:20:28 -0700 (PDT) Date: Mon, 2 Aug 2021 16:20:24 +0000 From: Sean Christopherson To: Zeng Guang Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , "kvm@vger.kernel.org" , Dave Hansen , "Luck, Tony" , Kan Liang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kim Phillips , Jarkko Sakkinen , Jethro Beekman , "Huang, Kai" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "Hu, Robert" , "Gao, Chao" , Robert Hoo Subject: Re: [PATCH 1/6] x86/feat_ctl: Add new VMX feature, Tertiary VM-Execution control Message-ID: References: <20210716064808.14757-1-guang.zeng@intel.com> <20210716064808.14757-2-guang.zeng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 02, 2021, Zeng Guang wrote: > On 7/29/2021 7:44 AM, Sean Christopherson wrote: > > On Fri, Jul 16, 2021, Zeng Guang wrote: > > > @@ -42,6 +44,13 @@ static void init_vmx_capabilities(struct cpuinfo_x86 *c) > > > rdmsr_safe(MSR_IA32_VMX_PROCBASED_CTLS2, &ign, &supported); > > > c->vmx_capability[SECONDARY_CTLS] = supported; > > > + /* > > > + * For tertiary execution controls MSR, it's actually a 64bit allowed-1. > > > + */ > > > + rdmsr_safe(MSR_IA32_VMX_PROCBASED_CTLS3, &ign, &supported); > > > + c->vmx_capability[TERTIARY_CTLS_LOW] = ign; > > > + c->vmx_capability[TERTIARY_CTLS_HIGH] = supported; > > Assuming only the lower 32 bits are going to be used for the near future (next > > few years), what about defining just TERTIARY_CTLS_LOW and then doing: > > > > /* > > * Tertiary controls are 64-bit allowed-1, so unlikely other MSRs, the > > * upper bits are ignored (because they're not used, yet...). > > */ > > rdmsr_safe(MSR_IA32_VMX_PROCBASED_CTLS3, &supported, &ign); > > c->vmx_capability[TERTIARY_CTLS_LOW] = supported; > > > > I.e. punt the ugliness issue down the road a few years. > Prefer to keep it complete, and use new variables like low/high consistent > with its function meaning. Ok for that ? Ya, either way works.