From: Heiko Carstens <hca@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
frankja@linux.ibm.com, cohuck@redhat.com, david@redhat.com,
thuth@redhat.com, imbrenda@linux.ibm.com, gor@linux.ibm.com
Subject: Re: [PATCH v3 3/3] s390x: optimization of the check for CPU topology change
Date: Tue, 3 Aug 2021 10:42:37 +0200 [thread overview]
Message-ID: <YQkBfal/OiI2y1lA@osiris> (raw)
In-Reply-To: <1627979206-32663-4-git-send-email-pmorel@linux.ibm.com>
On Tue, Aug 03, 2021 at 10:26:46AM +0200, Pierre Morel wrote:
> Now that the PTF instruction is interpreted by the SIE we can optimize
> the arch_update_cpu_topology callback to check if there is a real need
> to update the topology by using the PTF instruction.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> arch/s390/kernel/topology.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c
> index 26aa2614ee35..741cb447e78e 100644
> --- a/arch/s390/kernel/topology.c
> +++ b/arch/s390/kernel/topology.c
> @@ -322,6 +322,9 @@ int arch_update_cpu_topology(void)
> struct device *dev;
> int cpu, rc;
>
> + if (!ptf(PTF_CHECK))
> + return 0;
> +
We have a timer which checks if topology changed and then triggers a
call to arch_update_cpu_topology() via rebuild_sched_domains().
With this change topology changes would get lost.
next prev parent reply other threads:[~2021-08-03 8:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 8:26 [PATCH v3 0/3] s390x: KVM: CPU Topology Pierre Morel
2021-08-03 8:26 ` [PATCH v3 1/3] s390x: KVM: accept STSI for CPU topology information Pierre Morel
2021-08-31 13:59 ` David Hildenbrand
2021-09-01 9:43 ` Pierre Morel
2021-09-06 18:14 ` David Hildenbrand
2021-09-07 10:11 ` Pierre Morel
2021-08-03 8:26 ` [PATCH v3 2/3] s390x: KVM: Implementation of Multiprocessor Topology-Change-Report Pierre Morel
2021-08-31 14:03 ` David Hildenbrand
2021-09-01 9:46 ` Pierre Morel
2021-09-06 18:37 ` David Hildenbrand
2021-09-07 10:24 ` Pierre Morel
2021-09-08 7:04 ` Christian Borntraeger
2021-09-08 12:00 ` Pierre Morel
2021-09-08 12:01 ` Christian Borntraeger
2021-09-08 12:52 ` Pierre Morel
2021-09-07 12:28 ` Pierre Morel
2021-09-08 7:07 ` Christian Borntraeger
2021-09-08 13:09 ` Pierre Morel
2021-09-08 13:16 ` Christian Borntraeger
2021-09-08 14:17 ` Pierre Morel
2021-09-09 9:03 ` Pierre Morel
2021-08-03 8:26 ` [PATCH v3 3/3] s390x: optimization of the check for CPU topology change Pierre Morel
2021-08-03 8:42 ` Heiko Carstens [this message]
2021-08-03 8:57 ` Pierre Morel
2021-08-03 9:28 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQkBfal/OiI2y1lA@osiris \
--to=hca@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).