From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Mark Gross <mgross@linux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/surface: aggregator: Ouse y instead of objs in Makefile
Date: Tue, 3 Aug 2021 22:21:38 +0300 [thread overview]
Message-ID: <YQmXQlZqoUCHhSdn@smile.fi.intel.com> (raw)
In-Reply-To: <d8d1837a-583b-3926-5057-755acc84a5c9@gmail.com>
On Tue, Aug 03, 2021 at 08:40:10PM +0200, Maximilian Luz wrote:
> On 8/3/21 7:50 PM, Andy Shevchenko wrote:
> > The 'objs' is for user space tools, for the kernel modules
> > we should use 'y'.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thank you! I was previously not aware of that distinction. Two small
> notes:
>
> - There is a typo in the subject line.
> - With that change, the ifeq could be placed in-line (see note below).
Will address both.
> All in all looks good to me (assuming the typo gets fixed).
>
> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-08-03 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 17:50 [PATCH v1 1/1] platform/surface: aggregator: Ouse y instead of objs in Makefile Andy Shevchenko
2021-08-03 18:40 ` Maximilian Luz
2021-08-03 19:21 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQmXQlZqoUCHhSdn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).