From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71959C4320E for ; Wed, 4 Aug 2021 00:04:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54D4061050 for ; Wed, 4 Aug 2021 00:04:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234616AbhHDAEr (ORCPT ); Tue, 3 Aug 2021 20:04:47 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:43159 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232641AbhHDAEq (ORCPT ); Tue, 3 Aug 2021 20:04:46 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 17404I00014990 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Aug 2021 20:04:19 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 629A515C3DEA; Tue, 3 Aug 2021 20:04:18 -0400 (EDT) Date: Tue, 3 Aug 2021 20:04:18 -0400 From: "Theodore Ts'o" To: Matthew Wilcox Cc: Linus Torvalds , "Leonidas P. Papadakos" , Konstantin Komarov , zajec5@gmail.com, "Darrick J. Wong" , Greg Kroah-Hartman , Hans de Goede , linux-fsdevel , Linux Kernel Mailing List , Al Viro Subject: Re: [GIT PULL] vboxsf fixes for 5.14-1 Message-ID: References: <4e8c0640-d781-877c-e6c5-ed5cc09443f6@gmail.com> <20210716114635.14797-1-papadakospan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 12:44:38AM +0100, Matthew Wilcox wrote: > > I don't understand how so many ntfs-classic xfstests pass: > > config NTFS_RW > bool "NTFS write support" > depends on NTFS_FS > help > This enables the partial, but safe, write support in the NTFS driver. > > The only supported operation is overwriting existing files, without > changing the file length. No file or directory creation, deletion or > renaming is possible. Note only non-resident files can be written to > so you may find that some very small files (<500 bytes or so) cannot > be written to. > > Are the tests really passing, or just claiming to pass? This was the ntfs provided by the Debian package ntfs-3g (which is the only source of a mkfs.ntfs that I could find, BTW). This is a fuse-based ntfs, not the in-kernel ntfs file system. Apologies for not making that clear. {/usr/projects/linux/ext4}, level 2 (ntfs3) 1003# mkfs.ntfs /dev/cwcc-vg/scratch Cluster size has been automatically set to 4096 bytes. Initializing device with zeroes: 100% - Done. Creating NTFS volume structures. mkntfs completed successfully. Have a nice day. {/usr/projects/linux/ext4}, level 2 (ntfs3) 1004# mount -t ntfs /dev/cwcc-vg/scratch /mnt {/usr/projects/linux/ext4}, level 2 (ntfs3) 1005# grep /mnt /proc/mounts /dev/mapper/cwcc--vg-scratch /mnt fuseblk rw,relatime,user_id=0,group_id=0,allow_other,blksize=4096 0 0 TBH, I had forgotten that we had an in-kernel ntfs implementation. Whenver I've ever needed to access ntfs files, I've always used the ntfs-3g FUSE package. - Ted