From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Chao Yu <chao.yu@linux.dev>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent
Date: Wed, 4 Aug 2021 19:53:32 -0700 [thread overview]
Message-ID: <YQtSrIx0/sAipDs4@google.com> (raw)
In-Reply-To: <0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org>
On 08/05, Chao Yu wrote:
> Jaegeuk,
>
> On 2021/8/5 7:45, Jaegeuk Kim wrote:
> > Chao,
> >
> > How about this?
> > https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0
>
> Looks more clean, thanks,
>
> >
> > I'm digging one bug in __insert_extent_tree w/ the patch tho.
>
> Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise,
> __try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check
> w/ uninitialized c_len of @ei.
Fixed some bugs, but still getting another data corruption.
https://github.com/jaegeuk/f2fs/commit/c5d97919c55b467392407b60c1a7b1e3e81721ff
>
> > > On 08/04, Chao Yu wrote:
> > > > + if (from_dnode)
> > > > + goto skip_reading_dnode;
>
> Wrong condition here, thanks for fixing.
>
> Thanks,
next prev parent reply other threads:[~2021-08-05 2:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 2:23 [RFC v3] f2fs: extent cache: support unaligned extent Chao Yu
2021-08-04 21:37 ` Jaegeuk Kim
2021-08-04 23:45 ` [f2fs-dev] " Jaegeuk Kim
2021-08-05 0:29 ` Chao Yu
2021-08-05 2:53 ` Jaegeuk Kim [this message]
2021-08-05 3:04 ` Chao Yu
2021-08-05 3:14 ` Chao Yu
2021-08-05 13:35 ` Chao Yu
2021-08-05 18:36 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQtSrIx0/sAipDs4@google.com \
--to=jaegeuk@kernel.org \
--cc=chao.yu@linux.dev \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).