From: Lee Jones <lee.jones@linaro.org>
To: Vincent Pelletier <plr.vincent@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Support Opensource <support.opensource@diasemi.com>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
Subject: Re: [PATCH v3 1/3] mfd: da9063: Add HWMON dependencies
Date: Thu, 5 Aug 2021 12:40:13 +0100 [thread overview]
Message-ID: <YQvOHWAwG2xTIWMy@google.com> (raw)
In-Reply-To: <c06db13bb5076a8ee48e38a74caf3b81e4a2d1f8.1625662290.git.plr.vincent@gmail.com>
On Wed, 07 Jul 2021, Vincent Pelletier wrote:
> From: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
>
> Dependencies required for DA9063 HWMON support.
>
> Signed-off-by: Opensource [Steve Twiss] <stwiss.opensource@diasemi.com>
>
> Moved temperature offset reading to hwmon driver.
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
Nit: Please remove the empty lines between tags.
And format like this please:
[vincent: Moved temperature offset reading to hwmon driver]
> ---
> Changes in v3:
> - moved temperature offset reading to hwmon driver
>
> Changes in v2:
> - registers.h changes moved from patch 2
>
> Originally submitted by Steve Twiss in 2014:
> https://marc.info/?l=linux-kernel&m=139560864709852&w=2
>
> include/linux/mfd/da9063/registers.h | 34 ++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
Once fixed:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-08-05 11:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 13:25 [PATCH v3 1/3] mfd: da9063: Add HWMON dependencies Vincent Pelletier
2021-07-07 13:25 ` [PATCH v3 2/3] hwmon: da9063: HWMON driver Vincent Pelletier
2021-07-10 16:08 ` Guenter Roeck
2021-07-11 1:15 ` Vincent Pelletier
2021-07-11 2:55 ` Vincent Pelletier
2021-07-11 4:22 ` Guenter Roeck
2021-07-11 11:39 ` Vincent Pelletier
2021-07-11 15:14 ` Guenter Roeck
2021-07-11 4:44 ` Vincent Pelletier
2021-07-11 4:58 ` Randy Dunlap
2021-07-11 5:22 ` Vincent Pelletier
2021-07-11 5:45 ` Guenter Roeck
2021-07-07 13:25 ` [PATCH v3 3/3] Documentation: hwmon: New information for DA9063 Vincent Pelletier
2021-07-10 16:17 ` Guenter Roeck
2021-08-05 11:40 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQvOHWAwG2xTIWMy@google.com \
--to=lee.jones@linaro.org \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=plr.vincent@gmail.com \
--cc=stwiss.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).