From: Lee Jones <lee.jones@linaro.org>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Linus Walleij <linus.walleij@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>
Subject: Re: [PATCH] mfd: Don't use irq_create_mapping() to resolve a mapping
Date: Thu, 5 Aug 2021 12:41:27 +0100 [thread overview]
Message-ID: <YQvOZy48/DBzA5ao@google.com> (raw)
In-Reply-To: <20210725180754.250163-1-maz@kernel.org>
On Sun, 25 Jul 2021, Marc Zyngier wrote:
> Although irq_create_mapping() is able to deal with duplicate
> mappings, it really isn't supposed to be a substitute for
> irq_find_mapping(), and can result in allocations that take place
> in atomic context if the mapping didn't exist.
>
> Fix the handful of MFD drivers that use irq_create_mapping() in
> interrupt context by using irq_find_mapping() instead.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> drivers/mfd/ab8500-core.c | 2 +-
> drivers/mfd/stmpe.c | 4 ++--
> drivers/mfd/tc3589x.c | 2 +-
> drivers/mfd/wm8994-irq.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-08-05 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 18:07 [PATCH] mfd: Don't use irq_create_mapping() to resolve a mapping Marc Zyngier
2021-08-05 11:41 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQvOZy48/DBzA5ao@google.com \
--to=lee.jones@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=kernel-team@android.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).