* [PATCH v1 2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP)
2021-06-23 14:01 [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST) Andy Shevchenko
@ 2021-06-23 14:01 ` Andy Shevchenko
2021-08-05 13:53 ` Lorenzo Pieralisi
2021-07-12 14:00 ` [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST) Andy Shevchenko
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2021-06-23 14:01 UTC (permalink / raw)
To: linux-pci, linux-kernel
Cc: Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas, Andy Shevchenko
The "depends on" is no-op in the selectable options.
Clean up the users of PCIE_DW_EP and introduce idiom
depends on PCI_ENDPOINT
select PCIE_DW_EP
for all of them.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pci/controller/dwc/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 9bfd41eadd5e..ca5de4e40fbe 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -12,7 +12,6 @@ config PCIE_DW_HOST
config PCIE_DW_EP
bool
- depends on PCI_ENDPOINT
select PCIE_DW
config PCI_DRA7XX
@@ -37,8 +36,8 @@ config PCI_DRA7XX_HOST
config PCI_DRA7XX_EP
bool "TI DRA7xx PCIe controller Endpoint Mode"
depends on SOC_DRA7XX || COMPILE_TEST
- depends on PCI_ENDPOINT
depends on OF && HAS_IOMEM && TI_PIPE3
+ depends on PCI_ENDPOINT
select PCIE_DW_EP
select PCI_DRA7XX
help
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v1 2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP)
2021-06-23 14:01 ` [PATCH v1 2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP) Andy Shevchenko
@ 2021-08-05 13:53 ` Lorenzo Pieralisi
0 siblings, 0 replies; 9+ messages in thread
From: Lorenzo Pieralisi @ 2021-08-05 13:53 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-pci, linux-kernel, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas
On Wed, Jun 23, 2021 at 05:01:03PM +0300, Andy Shevchenko wrote:
> The "depends on" is no-op in the selectable options.
Same as in patch one, spell out what "depends on" you are referring
to - please make this log more descriptive.
Thanks,
Lorenzo
>
> Clean up the users of PCIE_DW_EP and introduce idiom
>
> depends on PCI_ENDPOINT
> select PCIE_DW_EP
>
> for all of them.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pci/controller/dwc/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 9bfd41eadd5e..ca5de4e40fbe 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -12,7 +12,6 @@ config PCIE_DW_HOST
>
> config PCIE_DW_EP
> bool
> - depends on PCI_ENDPOINT
> select PCIE_DW
>
> config PCI_DRA7XX
> @@ -37,8 +36,8 @@ config PCI_DRA7XX_HOST
> config PCI_DRA7XX_EP
> bool "TI DRA7xx PCIe controller Endpoint Mode"
> depends on SOC_DRA7XX || COMPILE_TEST
> - depends on PCI_ENDPOINT
> depends on OF && HAS_IOMEM && TI_PIPE3
> + depends on PCI_ENDPOINT
> select PCIE_DW_EP
> select PCI_DRA7XX
> help
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST)
2021-06-23 14:01 [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST) Andy Shevchenko
2021-06-23 14:01 ` [PATCH v1 2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP) Andy Shevchenko
@ 2021-07-12 14:00 ` Andy Shevchenko
2021-08-05 13:52 ` Lorenzo Pieralisi
2021-10-05 9:36 ` Lorenzo Pieralisi
3 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2021-07-12 14:00 UTC (permalink / raw)
To: linux-pci, linux-kernel
Cc: Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas
On Wed, Jun 23, 2021 at 05:01:02PM +0300, Andy Shevchenko wrote:
> First of all, the "depends on" is no-op in the selectable options.
> Second, no need to repeat menu dependencies (PCI).
>
> Clean up the users of PCIE_DW_HOST and introduce idiom
>
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
>
> for all of them.
Any comments on the series?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST)
2021-06-23 14:01 [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST) Andy Shevchenko
2021-06-23 14:01 ` [PATCH v1 2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP) Andy Shevchenko
2021-07-12 14:00 ` [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST) Andy Shevchenko
@ 2021-08-05 13:52 ` Lorenzo Pieralisi
2021-08-05 16:35 ` Andy Shevchenko
2021-10-05 9:36 ` Lorenzo Pieralisi
3 siblings, 1 reply; 9+ messages in thread
From: Lorenzo Pieralisi @ 2021-08-05 13:52 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-pci, linux-kernel, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas
On Wed, Jun 23, 2021 at 05:01:02PM +0300, Andy Shevchenko wrote:
> First of all, the "depends on" is no-op in the selectable options.
> Second, no need to repeat menu dependencies (PCI).
I believe you need to rewrite the commit log in a more descriptive
way - as it is it is not very descriptive.
Define which specific "depends on" you are referring to.
I appreciate the intent and I believe the patch is sound.
> Clean up the users of PCIE_DW_HOST and introduce idiom
>
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
>
> for all of them.
"All of them" ? We need something more explicit for this log
to be useful, it took me a while to understand the end result
you are achieving.
Thanks,
Lorenzo
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pci/controller/dwc/Kconfig | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 423d35872ce4..9bfd41eadd5e 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -8,7 +8,6 @@ config PCIE_DW
>
> config PCIE_DW_HOST
> bool
> - depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW
>
> config PCIE_DW_EP
> @@ -22,8 +21,8 @@ config PCI_DRA7XX
> config PCI_DRA7XX_HOST
> bool "TI DRA7xx PCIe controller Host Mode"
> depends on SOC_DRA7XX || COMPILE_TEST
> - depends on PCI_MSI_IRQ_DOMAIN
> depends on OF && HAS_IOMEM && TI_PIPE3
> + depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
> select PCI_DRA7XX
> default y if SOC_DRA7XX
> @@ -55,7 +54,7 @@ config PCIE_DW_PLAT
>
> config PCIE_DW_PLAT_HOST
> bool "Platform bus based DesignWare PCIe Controller - Host mode"
> - depends on PCI && PCI_MSI_IRQ_DOMAIN
> + depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
> select PCIE_DW_PLAT
> help
> @@ -138,8 +137,8 @@ config PCI_LAYERSCAPE
> bool "Freescale Layerscape PCIe controller - Host mode"
> depends on OF && (ARM || ARCH_LAYERSCAPE || COMPILE_TEST)
> depends on PCI_MSI_IRQ_DOMAIN
> - select MFD_SYSCON
> select PCIE_DW_HOST
> + select MFD_SYSCON
> help
> Say Y here if you want to enable PCIe controller support on Layerscape
> SoCs to work in Host mode.
> @@ -244,8 +243,8 @@ config PCIE_HISI_STB
>
> config PCI_MESON
> tristate "MESON PCIe controller"
> - depends on PCI_MSI_IRQ_DOMAIN
> default m if ARCH_MESON
> + depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
> help
> Say Y here if you want to enable PCI controller support on Amlogic
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST)
2021-08-05 13:52 ` Lorenzo Pieralisi
@ 2021-08-05 16:35 ` Andy Shevchenko
2021-08-10 16:59 ` Lorenzo Pieralisi
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2021-08-05 16:35 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: linux-pci, linux-kernel, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas
On Thu, Aug 05, 2021 at 02:52:34PM +0100, Lorenzo Pieralisi wrote:
> On Wed, Jun 23, 2021 at 05:01:02PM +0300, Andy Shevchenko wrote:
> > First of all, the "depends on" is no-op in the selectable options.
> > Second, no need to repeat menu dependencies (PCI).
> Define which specific "depends on" you are referring to.
I didn't get this because it stands right. It's in general.
I can be more specific since it's in align with the code,
though.
All the rest I agree with.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST)
2021-08-05 16:35 ` Andy Shevchenko
@ 2021-08-10 16:59 ` Lorenzo Pieralisi
0 siblings, 0 replies; 9+ messages in thread
From: Lorenzo Pieralisi @ 2021-08-10 16:59 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-pci, linux-kernel, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas
On Thu, Aug 05, 2021 at 07:35:38PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 05, 2021 at 02:52:34PM +0100, Lorenzo Pieralisi wrote:
> > On Wed, Jun 23, 2021 at 05:01:02PM +0300, Andy Shevchenko wrote:
> > > First of all, the "depends on" is no-op in the selectable options.
> > > Second, no need to repeat menu dependencies (PCI).
>
> > Define which specific "depends on" you are referring to.
>
> I didn't get this because it stands right. It's in general.
Ok, understood what you meant now - I read it as if you were referring
to a specific Kconfig entry that this patch is fixing.
Maybe:
"The "depends on" Kconfig construct is a no-op in options that
are selected and therefore has no effect. Remove it.".
> I can be more specific since it's in align with the code,
> though.
>
> All the rest I agree with.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST)
2021-06-23 14:01 [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST) Andy Shevchenko
` (2 preceding siblings ...)
2021-08-05 13:52 ` Lorenzo Pieralisi
@ 2021-10-05 9:36 ` Lorenzo Pieralisi
2021-10-05 12:04 ` Andy Shevchenko
3 siblings, 1 reply; 9+ messages in thread
From: Lorenzo Pieralisi @ 2021-10-05 9:36 UTC (permalink / raw)
To: linux-pci, linux-kernel, Andy Shevchenko
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas
On Wed, 23 Jun 2021 17:01:02 +0300, Andy Shevchenko wrote:
> First of all, the "depends on" is no-op in the selectable options.
> Second, no need to repeat menu dependencies (PCI).
>
> Clean up the users of PCIE_DW_HOST and introduce idiom
>
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
>
> [...]
Applied to pci/dwc, thanks!
[1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST)
https://git.kernel.org/lpieralisi/pci/c/a0ac7ee069
[2/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_EP)
https://git.kernel.org/lpieralisi/pci/c/2d614eea21
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/2] PCI: dwc: Clean up Kconfig dependencies (PCIE_DW_HOST)
2021-10-05 9:36 ` Lorenzo Pieralisi
@ 2021-10-05 12:04 ` Andy Shevchenko
0 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2021-10-05 12:04 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: linux-pci, linux-kernel, Krzysztof Wilczyński, Rob Herring,
Bjorn Helgaas
On Tue, Oct 05, 2021 at 10:36:09AM +0100, Lorenzo Pieralisi wrote:
> On Wed, 23 Jun 2021 17:01:02 +0300, Andy Shevchenko wrote:
> > First of all, the "depends on" is no-op in the selectable options.
> > Second, no need to repeat menu dependencies (PCI).
> >
> > Clean up the users of PCIE_DW_HOST and introduce idiom
> >
> > depends on PCI_MSI_IRQ_DOMAIN
> > select PCIE_DW_HOST
> >
> > [...]
>
> Applied to pci/dwc, thanks!
Sorry I have had no time to address your comments, but it seems you did it for
me, thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread