From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Don <joshdon@google.com>, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Paul Turner <pjt@google.com>, Oleg Rombakh <olegrom@google.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Steve Sistare <steven.sistare@oracle.com>,
Rik van Riel <riel@surriel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] sched: cgroup SCHED_IDLE support
Date: Thu, 5 Aug 2021 07:13:06 -1000 [thread overview]
Message-ID: <YQwcIpnKq3TYYIIL@mtj.duckdns.org> (raw)
In-Reply-To: <20210805101849.GH8057@worktop.programming.kicks-ass.net>
Hello,
On Thu, Aug 05, 2021 at 12:18:49PM +0200, Peter Zijlstra wrote:
> So I'm tempted to apply this, but last time TJ wasn't liking it much for
> the interface or somesuch. His argument that this encodes the
> hierarchical scheduling behaviour, but I'm not really buying that
> argument, as it doesn't really add more constraints than we already have
> by the hierarchical relative weight.
Interface-wise, writing 1 to idle file is fine. This does move away
the interface from being a purely semantical weight tree, which is a
concern and I have a difficult time seeing that the stated benefits
are significant enough to justify the changes. That said, this is
primarily a scheduler decision, so if you think the addition is
justified, please go ahead.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2021-08-05 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 2:00 [PATCH v2 0/2] SCHED_IDLE extensions Josh Don
2021-07-30 2:00 ` [PATCH v2 1/2] sched: cgroup SCHED_IDLE support Josh Don
2021-08-03 2:14 ` jun qian
2021-08-03 20:37 ` Josh Don
2021-08-05 10:18 ` Peter Zijlstra
2021-08-05 17:13 ` Tejun Heo [this message]
2021-08-05 23:54 ` Josh Don
2021-08-11 13:48 ` Vincent Guittot
2021-08-23 9:26 ` [tip: sched/core] sched: Cgroup " tip-bot2 for Josh Don
2021-07-30 2:00 ` [PATCH 2/2] sched: adjust SCHED_IDLE interactions Josh Don
2021-08-11 13:31 ` Vincent Guittot
2021-08-12 21:09 ` Josh Don
2021-08-13 12:43 ` Vincent Guittot
2021-08-13 23:55 ` Josh Don
2021-08-16 12:31 ` Peter Zijlstra
2021-08-17 23:48 ` Josh Don
2021-08-16 12:52 ` Peter Zijlstra
2021-08-16 12:56 ` Vincent Guittot
2021-08-17 23:40 ` Josh Don
2021-08-16 12:31 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQwcIpnKq3TYYIIL@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=olegrom@google.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=steven.sistare@oracle.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).