From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Mark Gross <mgross@linux.intel.com>
Subject: Re: [RFT, PATCH v1 1/1] platform/x86: dell-smo8800: Convert to be a platform driver
Date: Fri, 6 Aug 2021 12:04:13 +0300 [thread overview]
Message-ID: <YQz7DV4lOSD7+RJ8@smile.fi.intel.com> (raw)
In-Reply-To: <20210805192221.s7uoi5gh6zzkqinh@pali>
On Thu, Aug 05, 2021 at 09:22:21PM +0200, Pali Rohár wrote:
> On Tuesday 03 August 2021 22:40:39 Andy Shevchenko wrote:
> > ACPI core in conjunction with platform driver core provides
> > an infrastructure to enumerate ACPI devices. Use it in order
> > to remove a lot of boilerplate code.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Tested on Dell Latitude E6440. After applying this patch /dev/freefall
> device is created and can be opened (for waiting for disk fall). Also
> interrupt is registered in /proc/interrupts file:
>
> 23: 0 0 0 0 IR-IO-APIC 23-edge smo8800
>
> But I have not done real hard disk fall on this machine :-) so I guess
> it would work as before applying this patch.
At least the change doesn't touch any functional parts except device driver
enumeration.
> Reviewed-by: Pali Rohár <pali@kernel.org>
> Tested-by: Pali Rohár <pali@kernel.org>
Thank you!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-06 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 19:40 [RFT, PATCH v1 1/1] platform/x86: dell-smo8800: Convert to be a platform driver Andy Shevchenko
2021-08-04 20:00 ` Pali Rohár
[not found] ` <CAHp75Vc1r+9N6_BiJzO3JYppgaokKiQwk4sLrp72kPEDgYEweg@mail.gmail.com>
2021-08-05 8:11 ` Pali Rohár
2021-08-05 8:29 ` Andy Shevchenko
2021-08-05 19:22 ` Pali Rohár
2021-08-06 9:04 ` Andy Shevchenko [this message]
2021-08-06 13:46 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQz7DV4lOSD7+RJ8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).