From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E51C432BE for ; Thu, 19 Aug 2021 00:59:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA3B9610E5 for ; Thu, 19 Aug 2021 00:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235227AbhHSBAS (ORCPT ); Wed, 18 Aug 2021 21:00:18 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:55820 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235658AbhHSBAC (ORCPT ); Wed, 18 Aug 2021 21:00:02 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R221e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UjtBNTL_1629334764; Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0UjtBNTL_1629334764) by smtp.aliyun-inc.com(127.0.0.1); Thu, 19 Aug 2021 08:59:26 +0800 Date: Thu, 19 Aug 2021 08:59:24 +0800 From: Gao Xiang To: Liu Bo Cc: linux-erofs@lists.ozlabs.org, Chao Yu , LKML , Peng Tao , Eryu Guan , Liu Jiang , Joseph Qi Subject: Re: [PATCH 1/2] erofs: introduce chunk-based file on-disk format Message-ID: References: <20210818070713.4437-1-hsiangkao@linux.alibaba.com> <20210818222804.GA73193@rsjd01523.et2sqa> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210818222804.GA73193@rsjd01523.et2sqa> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bo, On Thu, Aug 19, 2021 at 06:28:04AM +0800, Liu Bo wrote: > On Wed, Aug 18, 2021 at 03:07:12PM +0800, Gao Xiang wrote: ... > > + EROFS_INODE_CHUNK_BASED = 4, > > EROFS_INODE_DATALAYOUT_MAX > > }; > > > > @@ -90,6 +96,19 @@ static inline bool erofs_inode_is_data_compressed(unsigned int datamode) > > #define EROFS_I_ALL \ > > ((1 << (EROFS_I_DATALAYOUT_BIT + EROFS_I_DATALAYOUT_BITS)) - 1) > > > > +/* indicate chunk blkbits, thus `chunksize = blocksize << chunk blkbits' */ > > A typo in the quotation marks. (`chunksize = ) should be ('chunksize =) Such usage is like below: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0e389028ad75412ff624b304913bba14f8d46ec4 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=78128fabd022240852859c0b253972147593690b I'm fine in either way. I'll update it in the next version or when submitting. > > Otherwise it looks good. > > Reviewed-by: Liu Bo Thanks for the review! Thanks, Gao Xiang > > thanks, > liubo >