From: Christoph Hellwig <hch@infradead.org>
To: brookxu <brookxu.cn@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: use enumerate instead of integer in op_is_write()
Date: Fri, 20 Aug 2021 06:21:22 +0100 [thread overview]
Message-ID: <YR870nMzpojlhR3l@infradead.org> (raw)
In-Reply-To: <1629424512-29553-1-git-send-email-brookxu.cn@gmail.com>
On Fri, Aug 20, 2021 at 09:55:12AM +0800, brookxu wrote:
> From: Chunguang Xu <brookxu@tencent.com>
>
> For mask operation, using enumerate may be safer than integer.
Except that we are explicitly checking for least significant bit as
that is part of the encoding, not a specific enum value.
prev parent reply other threads:[~2021-08-20 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 1:55 [PATCH] block: use enumerate instead of integer in op_is_write() brookxu
2021-08-20 5:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR870nMzpojlhR3l@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).