From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F389C4338F for ; Fri, 20 Aug 2021 09:33:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39A0B6113B for ; Fri, 20 Aug 2021 09:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236762AbhHTJeD (ORCPT ); Fri, 20 Aug 2021 05:34:03 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:46656 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235313AbhHTJeC (ORCPT ); Fri, 20 Aug 2021 05:34:02 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R451e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0UkJoTcw_1629452002; Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0UkJoTcw_1629452002) by smtp.aliyun-inc.com(127.0.0.1); Fri, 20 Aug 2021 17:33:23 +0800 Date: Fri, 20 Aug 2021 17:33:21 +0800 From: Gao Xiang To: Chao Yu Cc: linux-erofs@lists.ozlabs.org, Liu Bo , LKML , Peng Tao , Eryu Guan , Liu Jiang , Joseph Qi , Tao Ma Subject: Re: [PATCH v2 2/2] erofs: support reading chunk-based uncompressed files Message-ID: References: <20210818070713.4437-1-hsiangkao@linux.alibaba.com> <20210819063310.177035-1-hsiangkao@linux.alibaba.com> <20210819063310.177035-2-hsiangkao@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 20, 2021 at 05:29:36PM +0800, Chao Yu wrote: > On 2021/8/20 17:12, Gao Xiang wrote: > > Hi Chao, > > > > On Fri, Aug 20, 2021 at 05:04:13PM +0800, Chao Yu wrote: > > > On 2021/8/19 14:33, Gao Xiang wrote: > > > > ... > > > > > > } > > > > +static int erofs_map_blocks(struct inode *inode, > > > > + struct erofs_map_blocks *map, int flags) > > > > +{ > > > > + struct super_block *sb = inode->i_sb; > > > > + struct erofs_inode *vi = EROFS_I(inode); > > > > + struct erofs_inode_chunk_index *idx; > > > > + struct page *page; > > > > + u64 chunknr; > > > > + unsigned int unit; > > > > + erofs_off_t pos; > > > > + int err = 0; > > > > + > > > > + if (map->m_la >= inode->i_size) { > > > > + /* leave out-of-bound access unmapped */ > > > > + map->m_flags = 0; > > > > + map->m_plen = 0; > > > > + goto out; > > > > + } > > > > + > > > > + if (vi->datalayout != EROFS_INODE_CHUNK_BASED) > > > > + return erofs_map_blocks_flatmode(inode, map, flags); > > > > + > > > > + if (vi->chunkformat & EROFS_CHUNK_FORMAT_INDEXES) > > > > + unit = sizeof(*idx); /* chunk index */ > > > > + else > > > > + unit = 4; /* block map */ > > > > > > You mean sizeof(__le32)? > > > > Yeah, sizeof(__le32) == 4, either way works for me. > > > > If some tendency about this, I will update when applying. > > Xiang, > > Yeah, I preper: > > #define EROFS_BLOCK_MAP_ENTRY_SIZE sizeof(__le32) > > unit = EROFS_BLOCK_MAP_ENTRY_SIZE; > > to improve readablity, but unit = sizeof(__le32) is fine as well. Ok, looks much better, let me revise v3 here. Thanks, Gao Xiang > > Thanks, > > > > > > > > > Otherwise it looks good to me. > > > > > > Reviewed-by: Chao Yu > > > > > > > Thanks for the review! > > > > Thanks, > > Gao Xiang > > > > > Thanks, > > >